Repository navigation
SQLite table dumping compatibility improvements. - #4205
Merged
Merged
Conversation
Member
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working through the retired Holiday machine at HackTheBox. I noticed that
sqlmapwas unable to dump some of the tables for SQLite backend. There were two reasons for this:SQLite supports implicit datatypes in the create table definition. The regex in
lib/core/common.pydid not consider this, and was failing to parse the create table statement. The first patch fixes this. See below for a brief before and after example:When dumping a table that has more rows than
CHECK_ZERO_COLUMNS_THRESHOLDan additional query is run. This query had the table name concatenated to db name, which was causing the query to fail and the column being filled withNULLvalues. As this is the same for each column, nothing is dumped from the table. The second patch addresses this by removing the db name.Hope these are of some use.