Skip to content

Now it can retreive password hashes for MSSQL#3416

Closed
iammosespaulr wants to merge 1 commit into
sqlmapproject:masterfrom
iammosespaulr:patch-1
Closed

Now it can retreive password hashes for MSSQL#3416
iammosespaulr wants to merge 1 commit into
sqlmapproject:masterfrom
iammosespaulr:patch-1

Conversation

@iammosespaulr

Copy link
Copy Markdown

earlier .... it was unable to do so ...

earlier .... it was unable to do so ...
@stamparm stamparm closed this Dec 23, 2018
@stamparm

Copy link
Copy Markdown
Member

It doesn't work like this. You have a specific case. You haven't researched what were the differences and you are trying to change it for all.

@stamparm

Copy link
Copy Markdown
Member

sysxlogins is covered with query, while sql_logins is covered with query2. You have JUST removed the usage of fn_varbintohexstr and mingled the order of execution.

To repeat. Without proper research you can't push this kind of changes.

@iammosespaulr

Copy link
Copy Markdown
Author

well ...
I'm sorry ... I just pushed it because ... It worked for me ... and It didn't work earlier ...
I'll generalise the solution and then push it ...
Thanks tho ... 😁

@stamparm

Copy link
Copy Markdown
Member

What version of MsSQL was it?

@iammosespaulr

Copy link
Copy Markdown
Author

it's MSSQL12 😁

@iammosespaulr

Copy link
Copy Markdown
Author

this was the error which I got earlier tho (remote) (pymssql.ProgrammingError) (208, "Invalid object name 'master..sysxlogins'.DB-Lib error message 20018, severity 16:\nGeneral SQL Server error: Check messages from the SQL Server\n")

@iammosespaulr

Copy link
Copy Markdown
Author

I'll set up a new pull request ...

@iammosespaulr

Copy link
Copy Markdown
Author

#3418 ... do check this out ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants