Skip to content

Fixed some grammar in a few files - #2417

Closed
Ekultek wants to merge 3 commits into
sqlmapproject:masterfrom
Ekultek:grammar
Closed

Fixed some grammar in a few files#2417
Ekultek wants to merge 3 commits into
sqlmapproject:masterfrom
Ekultek:grammar

Conversation

@Ekultek

@Ekultek Ekultek commented Feb 27, 2017

Copy link
Copy Markdown
Contributor

Fixed some grammatical flaws in a few files, added .idea/ to .gitignore because pycharm creates a .idea directory that nobody likes

@stamparm

stamparm commented Feb 27, 2017

Copy link
Copy Markdown
Member

There are lots of problems with your "grammar fixes". I am not sure where to begin:

  1. There is nothing wrong with the "Please, always use only valid parameter values so sqlmap could be able to run properly" because ""Could" is used to express possibility or past ability as well as to make suggestions and requests". You are proposing "...so sqlmap will be able to run properly" which doesn't have any sense at all.
  2. I don't see a grammar problem with "most probably web server instance hasn't recovered yet" while you are proposing "most probable cause is that, the web server" <- why is here a ','? Also, usage of that in this context is redundant
  3. "most probably caused by inability" is ok. Your "most probable cause is by inability" is a grammatical blasphemy
    ...

@stamparm stamparm closed this Feb 27, 2017
stamparm added a commit that referenced this pull request Feb 27, 2017
@Ekultek

Ekultek commented Feb 27, 2017

Copy link
Copy Markdown
Contributor Author

Four errornous is spelt erroneous.

Five "please wait few minutes" is incorrect grammar, should be "please wait a few minutes"

I mean dude if you want me to call you out on your grammar I will. But don't sit there and tell me I'm wrong when I'm not.

@stamparm

Copy link
Copy Markdown
Member

I've changed the "few minutes" to "a few minutes" in 7ea5248

stamparm added a commit that referenced this pull request Feb 27, 2017
@stamparm

Copy link
Copy Markdown
Member

With latest commit changed from "most probably" to "most likely"

@stamparm

Copy link
Copy Markdown
Member

I am not going to take any more suggestions from here into the consideration. Thank you

@Ekultek
Ekultek deleted the grammar branch February 27, 2017 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants