Repository navigation
Add a Resize columns to contents action and a row padding setting - #4250
Open
deepsidhu1313 wants to merge 2 commits into
Open
deepsidhu1313 wants to merge 2 commits into
deepsidhu1313 wants to merge 2 commits into
Conversation
The columns of the Browse Data tab are sized to their contents once when a table is opened, and a single column can be resized by double-clicking its header separator, but there was no way to fit all columns again after the data or the window had changed. Add a 'Resize columns to contents' entry to the column header context menu for that. The resize-and-cap logic that used to live in TableBrowser::fetchedData is moved to ExtendedTableWidget::fitColumnsToContents, which is shared by the automatic and the manual resize and is covered by a new offscreen test. Hidden columns are left alone and the existing 300 pixel cap is kept. See sqlitebrowser#2351
The height of the rows in the data browser and in the SQL results is the height of the data browser font plus a hard-coded 10 pixels, so there was no way to see more rows on the screen except for making the font smaller. Add a 'Row padding (px)' option to the Data Browser tab of the preferences. Its default of 10 keeps the current row height. Qt does not let the default section size of a header become lower than its minimum section size, which by default depends on the font of the row header and not on the font of the data. Set the minimum to the height of a line of text so that low padding values take effect. See sqlitebrowser#419
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent commits.
Refs #2351, #419