Repository navigation
Pin SQLean for the Windows on ARM build - #4247
Merged
Merged
Conversation
The Makefile of SQLean was reworked recently (the download-external target is gone and the other targets changed), so the patch which adds the ARM64 target no longer applies and the Windows on ARM job fails in all builds with 'error: Makefile: patch does not apply'. Build the last version of SQLean which the patch applies to until the patch has been adapted.
lucydodo
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile of SQLean was reworked recently (for example the download-external target is gone), so tools/windows/add_sqlean_arm64_target.patch no longer applies and the Windows on ARM job fails in every build with "error: Makefile: patch does not apply". Build the last version of SQLean which the patch applies to (315178b) until the patch has been adapted to the new Makefile. Checked locally: the patch applies there and prepare-dist, download-sqlite, download-external and compile-windows-arm64 all exist.