Repository navigation
Fix bare VALUES queries showing 0 rows in Execute SQL - #4243
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
The row loader appends a LIMIT/OFFSET clause to a query to load its rows in
chunks. SQLite does not accept a LIMIT clause directly after a VALUES clause,
so a statement like "VALUES (3),(1),(2)" could not be prepared and showed
0 rows without reporting any error. Use such a statement as a sub-query
("SELECT * FROM (VALUES ...) LIMIT n OFFSET m") instead, which keeps the lazy
population. Queries which already contain a LIMIT clause or a compound
operator and all other queries are loaded exactly as before.
Add test-row-loader which runs queries through SqliteTableModel and checks the
loaded rows, the row count and the statements which are used for the other
kinds of queries.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RowLoader appends LIMIT/OFFSET for lazy population, which SQLite rejects directly after a VALUES list, so for example VALUES (3),(1),(2) showed 0 rows. Queries starting with VALUES are now wrapped as SELECT * FROM () LIMIT .. OFFSET ... Other query shapes are unchanged.
New test-row-loader (27 cases; 12 failed before). Not handled: WITH ... VALUES.