Repository navigation
Feature/sort cycle - #4239
Open
deepsidhu1313 wants to merge 2 commits into
Open
Feature/sort cycle#4239deepsidhu1313 wants to merge 2 commits into
deepsidhu1313 wants to merge 2 commits into
Conversation
…ng and none Clicking the header of a sorted column only toggled between ascending and descending order, so removing the sorting required the separate 'Clear sorting' action. A new setting in the Data Browser preferences makes a click on a descending column remove the sorting instead, so repeated clicks cycle through ascending, descending and no sorting. This also works for Ctrl+click, where only the clicked column is removed from the sort columns. The default behaviour is unchanged. The decision how a click changes the sort columns moves from TableBrowser::headerClicked into sqlb::updateSortColumns so that it can be covered by a unit test.
New Record (Ctrl+Shift+N), Delete Record (Ctrl+Shift+D) and Revert Changes (Ctrl+Shift+R) had no keyboard shortcut. The two record actions are limited to the table browser which has the focus, so they do not clash when there are multiple browsers. The shortcuts are also added to the tool tips. A test checks that the actions have shortcuts which are unique among the actions and do not shadow standard keys.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to cycle column header sorting through ascending, descending and none
Clicking the header of a sorted column only toggled between ascending and descending order, so removing the sorting required the separate 'Clear sorting' action. A new setting in the Data Browser preferences makes a click on a descending column remove the sorting instead, so repeated clicks cycle through ascending, descending and no sorting. This also works for Ctrl+click, where only the clicked column is removed from the sort columns.
The default behaviour is unchanged.
The decision how a click changes the sort columns moves from TableBrowser::headerClicked into sqlb::updateSortColumns so that it can be covered by a unit test.
A test checks that the actions have shortcuts which are unique among the actions and do not shadow standard keys.