Repository navigation
Fix Duplicate Record for composite WITHOUT ROWID keys and UNIQUE columns - #4234
Open
deepsidhu1313 wants to merge 2 commits into
Open
deepsidhu1313 wants to merge 2 commits into
deepsidhu1313 wants to merge 2 commits into
Conversation
Duplicating a record in a WITHOUT ROWID table with a composite primary key failed with "NOT NULL constraint failed", because the empty record only got a key value for single column keys. Generate a key whose last column is max+1 (other key columns get a neutral value) so the insert succeeds, and return the composed sqlb_make_single_value identifier of the new row instead of the plain number so the model can find the row again. Columns covered by a UNIQUE constraint were copied into the new row, which always violated the constraint, showed an "Error changing data" dialog and left a half filled record. Like the primary key they are now not copied. Add test-duplicate-record covering these and the existing cases.
It was removed in Qt6. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicating a record in a WITHOUT ROWID table with a composite primary key failed with "NOT NULL constraint failed", because the empty record only got a key value for single column keys. Generate a key whose last column is max+1 (other key columns get a neutral value) so the insert succeeds, and return the composed sqlb_make_single_value identifier of the new row instead of the plain number so the model can find the row again.
Columns covered by a UNIQUE constraint were copied into the new row, which always violated the constraint, showed an "Error changing data" dialog and left a half filled record. Like the primary key they are now not copied.
Add test-duplicate-record covering these and the existing cases.