Repository navigation
Detect statement type in Execute SQL despite leading comments - #4233
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
RunSql::getQueryType() looked at the start of the statement text, but the text SQLite hands back for a statement includes any comments in front of it. A script like "-- compact\nVACUUM;" was therefore classified as an ordinary statement, wrapped in a savepoint and failed with "cannot VACUUM from within a transaction" (the same applies to VACUUM INTO and to PRAGMA statements that must run outside of a transaction). Skip whitespace and comments before matching the keyword. Add a test-run-sql target which runs scripts through RunSql against a real database.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunSql::getQueryType() looked at the start of the statement text, but the text SQLite hands back for a statement includes any comments in front of it. A script like "-- compact\nVACUUM;" was therefore classified as an ordinary statement, wrapped in a savepoint and failed with "cannot VACUUM from within a transaction" (the same applies to VACUUM INTO and to PRAGMA statements that must run outside of a transaction). Skip whitespace and comments before matching the keyword.
Add a test-run-sql target which runs scripts through RunSql against a real database.