Repository navigation
Fix foreign keys being skipped when renaming a column - #4226
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
Table::renameKeyInAllConstraints() looped over m_foreignKeys with for(...; ++it) while the match_and_rename helper already advances the iterator (it = container.erase(it)). After a rename the loop skipped the next foreign key, leaving it on the old column name, and when the renamed entry was the last one it incremented end(), which is undefined behaviour. Let the helper advance the iterator, like the index constraint loop above. Add tests for renaming keys in foreign keys and index constraints, and a regression test for moving an AUTOINCREMENT primary key (sqlitebrowser#3953). Likely fixes sqlitebrowser#3994 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
deepsidhu1313
force-pushed
the
fix/rename-foreign-key-iterator
branch
from
October 25, 2026 03:55
abe0a6c to
00dffe3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table::renameKeyInAllConstraints() looped over m_foreignKeys with for(...; ++it) while the match_and_rename helper already advances the iterator (it = container.erase(it)). After a rename the loop skipped the next foreign key, leaving it on the old column name, and when the renamed entry was the last one it incremented end(), which is undefined behaviour.
Let the helper advance the iterator, like the index constraint loop above.
Add tests for renaming keys in foreign keys and index constraints, and a regression test for moving an AUTOINCREMENT primary key (#3953).
Likely fixes #3994