Skip to content

Write proper SQL literals when copying or dragging a table from DB Schema #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anandghegde wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

Write proper SQL literals when copying or dragging a table from DB Schema #4199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/DbStructureModel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,19 @@ QMimeData* DbStructureModel::mimeData(const QModelIndexList& indices) const
{
QString insertStatement = "INSERT INTO " + QString::fromStdString(objid.toString()) + " VALUES(";
for(int j=1; j < tableModel.columnCount(); ++j)
insertStatement += QString("'%1',").arg(tableModel.data(tableModel.index(i, j), Qt::EditRole).toString());
{
// Write each value as a SQL literal, the same way "Copy as SQL" in the table grid does
const QModelIndex cell = tableModel.index(i, j);
const QVariant value = tableModel.data(cell, Qt::EditRole);
if(value.isNull())
insertStatement += "NULL,";
else if(tableModel.isBinary(cell))
insertStatement += QString("X'%1',").arg(QString(value.toByteArray().toHex()));
else if(value.type() == QVariant::LongLong || value.type() == QVariant::Double)
insertStatement += value.toString() + ",";
else
insertStatement += sqlb::escapeString(value.toString()) + ",";
}
insertStatement.chop(1);
insertStatement += ");\n";
sqlData.append(insertStatement.toUtf8());
Expand Down
Loading