Skip to content

Leave generated columns out of Export to SQL #4198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anandghegde wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −0
Open

Leave generated columns out of Export to SQL #4198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/sqlitedb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,19 @@ bool DBBrowserDB::dump(const QString& filePath,
// get columns
sqlb::StringVector cols = it->fieldNames();

// Generated columns cannot be inserted into, so leave them out of both the SELECT and the
// INSERT statements, like the sqlite3 shell's .dump does
std::string sQuery = "SELECT * FROM " + sqlb::escapeIdentifier(it->name());
if(std::any_of(it->fields.begin(), it->fields.end(), [](const sqlb::Field& f) { return f.generated() != nullptr; }))
{
cols.clear();
for(const sqlb::Field& f : it->fields)
{
if(!f.generated())
cols.push_back(f.name());
}
sQuery = "SELECT " + sqlb::joinStringVector(sqlb::escapeIdentifier(cols), ",") + " FROM " + sqlb::escapeIdentifier(it->name());
}
sqlite3_stmt *stmt;
QString lineSep(QString(")%1\n").arg(insertNewSyntx?',':';'));

Expand Down
Loading