Conversation
lucydodo
force-pushed
the
fix/3971-global-regex-filter
branch
from
September 3, 2026 11:31
7e14419 to
ac1334c
Compare
Member
|
Thank you for your contribution. However, I don't have the expertise to review this PR, so I'll wait for someone else to review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3971.
The global “Filter in any column” field split every literal space before passing terms to the existing condition parser. That turned
/New York/into two LIKE filters instead of one REGEXP filter.This change adds a finite tokenizer at that lexical boundary. It preserves slash-delimited regex terms atomically, keeps ordinary space-separated terms as AND conditions, handles escaped slash parity, and falls back to the previous split behavior for malformed or unmatched slash input. Existing condition parsing, query construction, per-column filters, and project XML remain unchanged.
Tests cover:
CondFormatandQuerypath (/New York/returns exactlyNew York)Verification:
Risk is limited to global-filter tokenization. Malformed slash input deliberately retains the previous behavior.