Update base and other Qt translations for installers - #4179
Open
ozgurerturk wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base qt translations for Turkish, Brazilian Portuguese, Swedish and Chinese (China) were missing or incomplete from windows, win64arm and ubuntu installers.
Updated the translations.wxs files to include missing translation files but installers were still not putting portuguese, swedish and chinese files to translations folder for some reason. So I updated the workflow steps for windows and ubuntu which checkouts the missing qm files from 5.15-tr branch of qt translations and then builds them through lrelease and adds them to translations folder.
Windows on ARM was using Qt 6.8.3 so just updating the translations.wxs for it was enough.
After:
Partially solves #1626 I think but I couldn't do it for OSX installer but I'm sure the same solution can be done with the macos cmake workflow.