Repository navigation
Avoid setting the db dirty with some trailing whitespace and comments - #1543
Merged
Merged
Conversation
If we execute a select statement and there is some trailing whitespace or comments in the buffer, we are passing that to SQLite and fooling ourselves thinking that it may be a query modifying the database. Since we aren't very smart about knowing which queries modify the database, this change at least avoids this particular case by breaking when there is only trailing whitespace and comments. The issue has probably origin in #1455, since previously we didn't pass the comments to SQLite.
Member
Author
|
This was reported in the comments of #1297 |
Member
|
Yep, I guess this is ok. The only thing to keep in mind here is that |
Member
Author
|
Yes, I'm aware of that and agree to all you've said. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we execute a select statement and there is some trailing whitespace or
comments in the buffer, we are passing that to SQLite and fooling
ourselves thinking that it may be a query modifying the database. Since
we aren't very smart about knowing which queries modify the database, this
change at least avoids this particular case by breaking when there is only
trailing whitespace and comments.
The issue has probably origin in #1455, since previously we didn't pass
the comments to SQLite.