You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Some strings in the main UI are not showing their translation #643
Some strings in the main UI aren't showing their translation. eg:
Apparently this happens for languages other than Arabic (eg French), which makes it sound like a problem in our code. Hopefully it's just a setting or something needing to be applied to the strings in the .ui file or similar.
Translation files are one huge mess, lines specified in .ts files are outdated and do not match lines in .ui files.
Even those translation strings that are displayed correctly atm - have wrong line numbers in .ts files. This requires a thorough work :)
I only know .NET programming, which is why I haven't gotten involved with programming/helping out before, but editing translation files sounds work I could be doing... matching up the lines and ensuring they're still valid? I'm good at the laborious stuff, leaving others time to do the exciting bits!
With this particular issue, I kind of wondered if maybe the punctuation symbols in some strings were doing weird things for the translations.
After a bit of investigation, it does seem like this is at least part of the problem.
For the French language example, here is what the UI looks like before investigating the punctuation symbols:
Picking one of the strings that hasn't translated - "Revert Changes" - doing a grep for it through the src/ subdirectory shows it in MainWindow.ui:
After adding the & string to the translation file here, then rebuilding the project, that string now translates correctly in the main interface:
So, it looks like string matching problems between the .ui files and the translation files for at least some of this.
@chrisjlocke Is going through the translations files and getting these adjusted to string match correctly something you'd be up for in the next few days? 😄
As a data point, this doesn't look to be too complicated. Just went through the French UI and fixed the main strings for the initial UI. I'll commit the change to our repo in a minute too:
I'll set up a VM following your examples / instructions to create a Windows development area and have a go... going through the files sounds doable, but 'rebuilding the project' is something I've not done before... but I like a challenge!*
The setup for the Win dev environment is kind of tedious. Lots of downloading at the start to collect things, then lots of launching installers, picking the options (as given 😄), then waiting for installers to finish. The only challenge for that bit is patience. 😉
Once you have that though, you're all set. The instructions take you through building the project, so you'll find "rebuilding" the project itself super simple.
Write. Sorry, right. I can spend tomorrow doing some more languages. I've seen most languages seem to have been completed, but unsure whether thats just the dialog or the full translations (I'm going through Qt Linguist, so doing the whole translation...) and I presume my 'bits' can't be merged with whats already been committed? (Guess I could ignore the UI translations where they've been posted). Sorry. Rambling now...
If there is a specific language you want me to do next, let me know...
Thanks Chris. Yeah, drop this for now. Several of the original translation authors responded positively to being contacted, and have either given us complete translations back or said they would.
There are a few who haven't, but it's probably something we can look at closer to the weekend. We might just leave those ones as-is for now. Thinking we'll call it at the time.
Activity
vtronko commentedon Jul 11, 2016
Translation files are one huge mess, lines specified in .ts files are outdated and do not match lines in .ui files.
Even those translation strings that are displayed correctly atm - have wrong line numbers in .ts files. This requires a thorough work :)
chrisjlocke commentedon Jul 12, 2016
I only know .NET programming, which is why I haven't gotten involved with programming/helping out before, but editing translation files sounds work I could be doing... matching up the lines and ensuring they're still valid? I'm good at the laborious stuff, leaving others time to do the exciting bits!
justinclift commentedon Jul 12, 2016
@chrisjlocke Any help with this would definitely be useful. 😀
justinclift commentedon Jul 12, 2016
With this particular issue, I kind of wondered if maybe the punctuation symbols in some strings were doing weird things for the translations.
After a bit of investigation, it does seem like this is at least part of the problem.
For the French language example, here is what the UI looks like before investigating the punctuation symbols:

Picking one of the strings that hasn't translated - "Revert Changes" - doing a grep for it through the src/ subdirectory shows it in MainWindow.ui:
In the French translation file though, it's missing the
&at the start:After adding the

&string to the translation file here, then rebuilding the project, that string now translates correctly in the main interface:So, it looks like string matching problems between the .ui files and the translation files for at least some of this.
@chrisjlocke Is going through the translations files and getting these adjusted to string match correctly something you'd be up for in the next few days? 😄
justinclift commentedon Jul 12, 2016
As a data point, this doesn't look to be too complicated. Just went through the French UI and fixed the main strings for the initial UI. I'll commit the change to our repo in a minute too:

Added punctuation to some French translations, so they match the UI s…
chrisjlocke commentedon Jul 12, 2016
I'll set up a VM following your examples / instructions to create a Windows development area and have a go... going through the files sounds doable, but 'rebuilding the project' is something I've not done before... but I like a challenge!*
*If supplied with enough beer and sweets.
justinclift commentedon Jul 13, 2016
Heh Heh Heh
The setup for the Win dev environment is kind of tedious. Lots of downloading at the start to collect things, then lots of launching installers, picking the options (as given 😄), then waiting for installers to finish. The only challenge for that bit is patience. 😉
Once you have that though, you're all set. The instructions take you through building the project, so you'll find "rebuilding" the project itself super simple.
If you hit stumbling things, reach out. 😄
justinclift commentedon Jul 20, 2016
@chrisjlocke Had a chance to look at this?
We'll probably do our next release next week, so this needs to be completed (+ verified) by then. 😄
chrisjlocke commentedon Jul 20, 2016
I'll set up a virtual machine this morning and follow your instructions. :)
justinclift commentedon Jul 20, 2016
Excellent, that will really help. 😄
chrisjlocke commentedon Jul 20, 2016
Yes, in the "Requirements" section, you need to add "4 days put aside to
install all this gumph"... ;)
43 remaining items
justinclift commentedon Aug 4, 2016
Chinese (Traditional)
justinclift commentedon Aug 4, 2016
English (British)
justinclift commentedon Aug 4, 2016
Turkish
Adjusted Arabic translation strings messed by punctuation changes (#702)
chrisjlocke commentedon Aug 5, 2016
I'll commit later what I've got - I've gone through about 6 languages completely, not just fixing the dialogs. Green ticks all round in Qt Linguist.
justinclift commentedon Aug 5, 2016
Thanks @chrisjlocke that should help a bunch. 😄
Make a PR for it though, don't just directly commit it.
justinclift commentedon Aug 5, 2016
@chrisjlocke By the way, which ones are those 6? I'll continue on with the others. 😄
justinclift commentedon Aug 5, 2016
Note, the Arabic translation has been redone completely today in #706. Looks like 100% coverage too, which is pretty awesome. 😁
chrisjlocke commentedon Aug 17, 2016
Write. Sorry, right. I can spend tomorrow doing some more languages. I've seen most languages seem to have been completed, but unsure whether thats just the dialog or the full translations (I'm going through Qt Linguist, so doing the whole translation...) and I presume my 'bits' can't be merged with whats already been committed? (Guess I could ignore the UI translations where they've been posted). Sorry. Rambling now...
If there is a specific language you want me to do next, let me know...
justinclift commentedon Aug 17, 2016
Thanks Chris. Yeah, drop this for now. Several of the original translation authors responded positively to being contacted, and have either given us complete translations back or said they would.
There are a few who haven't, but it's probably something we can look at closer to the weekend. We might just leave those ones as-is for now. Thinking we'll call it at the time.
justinclift commentedon Aug 24, 2016
Meh, we've done what we can for the 3.9.0 release. It's "good enough for now".
😉
Adjusted Arabic translation strings messed by punctuation changes (#702)