Skip to content

Some strings in the main UI are not showing their translation #643

Closed

Description

@justinclift

Some strings in the main UI aren't showing their translation. eg:
screen shot 2016-07-11 at 19 36 49
Apparently this happens for languages other than Arabic (eg French), which makes it sound like a problem in our code. Hopefully it's just a setting or something needing to be applied to the strings in the .ui file or similar.

Activity

  1. self-assigned this
    on Jul 11, 2016
  2. vtronko commented on Jul 11, 2016

    @vtronko
    Member

    Translation files are one huge mess, lines specified in .ts files are outdated and do not match lines in .ui files.
    Even those translation strings that are displayed correctly atm - have wrong line numbers in .ts files. This requires a thorough work :)

  3. chrisjlocke commented on Jul 12, 2016

    @chrisjlocke
    Member

    I only know .NET programming, which is why I haven't gotten involved with programming/helping out before, but editing translation files sounds work I could be doing... matching up the lines and ensuring they're still valid? I'm good at the laborious stuff, leaving others time to do the exciting bits!

  4. justinclift commented on Jul 12, 2016

    @justinclift
    MemberAuthor

    @chrisjlocke Any help with this would definitely be useful. 😀

  5. justinclift commented on Jul 12, 2016

    @justinclift
    MemberAuthor

    With this particular issue, I kind of wondered if maybe the punctuation symbols in some strings were doing weird things for the translations.

    After a bit of investigation, it does seem like this is at least part of the problem.

    For the French language example, here is what the UI looks like before investigating the punctuation symbols:
    screen shot 2016-07-12 at 13 43 01
    Picking one of the strings that hasn't translated - "Revert Changes" - doing a grep for it through the src/ subdirectory shows it in MainWindow.ui:

    <string>&amp;Revert Changes</string>
    

    In the French translation file though, it's missing the &amp; at the start:

    <source>Revert Changes</source>
    

    After adding the &amp; string to the translation file here, then rebuilding the project, that string now translates correctly in the main interface:
    screen shot 2016-07-12 at 13 53 56
    So, it looks like string matching problems between the .ui files and the translation files for at least some of this.

    @chrisjlocke Is going through the translations files and getting these adjusted to string match correctly something you'd be up for in the next few days? 😄

  6. justinclift commented on Jul 12, 2016

    @justinclift
    MemberAuthor

    As a data point, this doesn't look to be too complicated. Just went through the French UI and fixed the main strings for the initial UI. I'll commit the change to our repo in a minute too:
    screen shot 2016-07-12 at 14 08 20

  7. chrisjlocke commented on Jul 12, 2016

    @chrisjlocke
    Member

    I'll set up a VM following your examples / instructions to create a Windows development area and have a go... going through the files sounds doable, but 'rebuilding the project' is something I've not done before... but I like a challenge!*

    *If supplied with enough beer and sweets.

  8. justinclift commented on Jul 13, 2016

    @justinclift
    MemberAuthor

    Heh Heh Heh

    The setup for the Win dev environment is kind of tedious. Lots of downloading at the start to collect things, then lots of launching installers, picking the options (as given 😄), then waiting for installers to finish. The only challenge for that bit is patience. 😉

    Once you have that though, you're all set. The instructions take you through building the project, so you'll find "rebuilding" the project itself super simple.

    If you hit stumbling things, reach out. 😄

  9. justinclift commented on Jul 20, 2016

    @justinclift
    MemberAuthor

    @chrisjlocke Had a chance to look at this?

    We'll probably do our next release next week, so this needs to be completed (+ verified) by then. 😄

  10. chrisjlocke commented on Jul 20, 2016

    @chrisjlocke
    Member

    I'll set up a virtual machine this morning and follow your instructions. :)

  11. justinclift commented on Jul 20, 2016

    @justinclift
    MemberAuthor

    Excellent, that will really help. 😄

  12. chrisjlocke commented on Jul 20, 2016

    @chrisjlocke
    Member

    Yes, in the "Requirements" section, you need to add "4 days put aside to
    install all this gumph"... ;)

  13. 43 remaining items

  14. justinclift commented on Aug 4, 2016

    @justinclift
    MemberAuthor

    Chinese (Traditional)

    • CipherDialog.ui
    • ColumnDisplayFormatDialog.ui
    • CreateIndexDialog.ui
    • EditDialog.ui
    • EditTableDialog.ui
    • ExportCsvDialog.ui
    • ExportSqlDialog.ui
    • ImportCsvDialog.ui
    • MainWindow.ui
    • PreferencesDialog.ui
    • VacuumDialog.ui
  15. justinclift commented on Aug 4, 2016

    @justinclift
    MemberAuthor

    English (British)

    • CipherDialog.ui
    • ColumnDisplayFormatDialog.ui
    • CreateIndexDialog.ui
    • EditDialog.ui
    • EditTableDialog.ui
    • ExportCsvDialog.ui
    • ExportSqlDialog.ui
    • ImportCsvDialog.ui
    • MainWindow.ui
    • PreferencesDialog.ui
    • VacuumDialog.ui
  16. justinclift commented on Aug 4, 2016

    @justinclift
    MemberAuthor

    Turkish

    • CipherDialog.ui
    • ColumnDisplayFormatDialog.ui
    • CreateIndexDialog.ui
    • EditDialog.ui
    • EditTableDialog.ui
    • ExportCsvDialog.ui
    • ExportSqlDialog.ui
    • ImportCsvDialog.ui
    • MainWindow.ui
    • PreferencesDialog.ui
    • VacuumDialog.ui
  17. chrisjlocke commented on Aug 5, 2016

    @chrisjlocke
    Member

    I'll commit later what I've got - I've gone through about 6 languages completely, not just fixing the dialogs. Green ticks all round in Qt Linguist.

  18. justinclift commented on Aug 5, 2016

    @justinclift
    MemberAuthor

    Thanks @chrisjlocke that should help a bunch. 😄

    Make a PR for it though, don't just directly commit it.

  19. justinclift commented on Aug 5, 2016

    @justinclift
    MemberAuthor

    @chrisjlocke By the way, which ones are those 6? I'll continue on with the others. 😄

  20. justinclift commented on Aug 5, 2016

    @justinclift
    MemberAuthor

    Note, the Arabic translation has been redone completely today in #706. Looks like 100% coverage too, which is pretty awesome. 😁

  21. chrisjlocke commented on Aug 17, 2016

    @chrisjlocke
    Member

    Write. Sorry, right. I can spend tomorrow doing some more languages. I've seen most languages seem to have been completed, but unsure whether thats just the dialog or the full translations (I'm going through Qt Linguist, so doing the whole translation...) and I presume my 'bits' can't be merged with whats already been committed? (Guess I could ignore the UI translations where they've been posted). Sorry. Rambling now...
    If there is a specific language you want me to do next, let me know...

  22. justinclift commented on Aug 17, 2016

    @justinclift
    MemberAuthor

    Thanks Chris. Yeah, drop this for now. Several of the original translation authors responded positively to being contacted, and have either given us complete translations back or said they would.

    There are a few who haven't, but it's probably something we can look at closer to the weekend. We might just leave those ones as-is for now. Thinking we'll call it at the time.

  23. justinclift commented on Aug 24, 2016

    @justinclift
    MemberAuthor

    Meh, we've done what we can for the 3.9.0 release. It's "good enough for now".

    😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions