Skip to content

make install does nothing #29

Closed
Closed

Description

@Jonrysh

make install (invoked in the top level directory, containing BUILDING, ...) doesn't seem to do anything except produce output; no files are installed anywhere. The program has already been build using make, and seems to work fine.

Activity

  1. MKleusberg commented on May 27, 2014

    @MKleusberg
    Member

    You're using qmake, I suppose? Because we had some difficulties when it came to using extended features with qmake we've made the decision to move to cmake. We try to keep qmake support but only for a quick build; when it comes to a release build or things like make install I'd suggest using cmake. I hope this is an option for you :)

    (Disclaimer: I'm assuming here that we have install support when using cmake but never tried it myself, maybe Rene can confirm this...)

  2. rp- commented on May 27, 2014

    @rp-
    Contributor

    I didn't come around to add a useful install target to cmake.

    Right now we only have the binary as output file, no docs, no translations(yet) to install.
    This will get mandatory as soon as we have more additional runtime files.

  3. Jonrysh commented on May 28, 2014

    @Jonrysh
    Author

    On Tue, 2014-05-27 at 11:20 -0700, Martin Kleusberg wrote:

    You're using qmake, I suppose? Because we had some difficulties when
    it came to using extended features with qmake we've made the decision
    to move to cmake. We try to keep qmake support but only for a quick
    build; when it comes to a release build or things like make install
    I'd suggest using cmake. I hope this is an option for you :)

    I downloaded sqlite-browser using the command:

        $ git clone https://github.com/sqlitebrowser/sqlitebrowser.git
    

    and invoked make (not cmake or qmake) on sqlitebrowser/Makefile. The

    sqlitebrowser binary generated seems to run OK.

    All the best - jon

    For I am a Bear of Very Little Brain, and
    long words bother me. -- Winnie the Pooh

  4. justinclift commented on May 28, 2014

    @justinclift
    Member

    Sounds like we should add build instructions for Linux too.

  5. Jonrysh commented on May 28, 2014

    @Jonrysh
    Author

    On Wed, 2014-05-28 at 15:28 -0700, Justin Clift wrote:

    Sounds like we should add build instructions for Linux too.

    I suspect there's a typo in BUILDING, which reads, in part:

        Provided you have Qt and cmake  installed and configured, simply
        run
    
        qmake
    
        followed by
    
        make
    

    When I find a Makefile in a build directory, I assume that the packager
    has already run whatever is needed to generate it, and that they have
    probably done a better job than I will (at least for a first cut), so in
    this cas I didn't run qmake. If you want sqlitebrowser to be built
    using cmake rather than make, the above should read:

        Provided you have Qt and cmake  installed and configured, simply
        run
    
        qmake
    
        followed by
    
        cmake
    

    If you want me to be sure to regenerate the Makefile using cmake, you

    need to say so very explicitly.

    All the best - jon

    "Do I contradict myself?
    Very well, I contradict myself,
    (I am large, I contain multitudes.)"
    -- Walt Whitman

  6. justinclift commented on May 28, 2014

    @justinclift
    Member

    Good point. 😄

    Which distribution/version of Linux are you using?

  7. Jonrysh commented on May 28, 2014

    @Jonrysh
    Author

    On Wed, 2014-05-28 at 16:32 -0700, Justin Clift wrote:

    Good point. 😄

    Which distribution/version of Linux are you using?

    Fedora-20, all updates installed.

    All the best - jon

    We are Pentium of Borg. Division is futile.
    You will be approximated. -- Joe Klemmer

  8. added a commit that references this issue on May 29, 2014
  9. MKleusberg commented on May 29, 2014

    @MKleusberg
    Member

    On Wednesday 28 May 2014 16:21:02 Jonrysh wrote:
    When I find a Makefile in a build directory, I assume that the packager has already run whatever is needed to generate it, and that they have probably done a better job than I will (at least for a first cut), so in this cas I didn't run qmake.

    Are you sure the Makefile was there after cloning the repository? Because as far as I see there is none checked in now. It might have been automatically created by Qt Creator, however, and Qt Creator relies on qmake by default.

    You are definitely right though in pointing out that the building instructions are wrong in asking to use qmake rather than cmake - especially after suggesting cmake to be installed. Good job in noticing this :) I've fixed it in the commit mentioned above.

  10. rp- commented on May 30, 2014

    @rp-
    Contributor

    just checked again, there is a install rule for cmake.
    It doesn't do much(copy sqlitebrowser to /usr/local/bin, but its there ;)

  11. Heart1010 commented on Sep 18, 2014

    @Heart1010

    ...so what do I have to do in order to be able to use sqlitebrowser on linux exactly (openSUSE 13.1 here)?

    Thanks

  12. Jonrysh commented on Sep 18, 2014

    @Jonrysh
    Author

    On Thu, 2014-09-18 at 03:32 -0700, Hermann Herz wrote:

    ...so what do I have to do in order to be able to use sqlitebrowser on
    linux exactly (openSUSE 13.1 here)?

    Build the binary as instructed. If "make install" doesn't put the
    binary in a useful place (say in /usr/bin) copy it to such a place by
    hand.

  13. justinclift commented on Sep 19, 2014

    @justinclift
    Member

    @Heart1010 Do the instructions in the BUILDING.md file work for you?

        https://github.com/sqlitebrowser/sqlitebrowser/blob/master/BUILDING.md

  14. justinclift commented on Oct 13, 2014

    @justinclift
    Member

    In theory, 'make install' should be working now.

    Does anyone have a few minutes to test and confirm success/failure? 😄

  15. justinclift commented on Jan 7, 2016

    @justinclift
    Member

    Closing this now, as "make install" is generally known to work ok.

    If for some reason it doesn't, please feel welcome to re-open this issue or create a new one (either is good). 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions