Skip to content

Nightly builds only on repo changes. #1917

Open

Description

@sky5walk

Describe the new feature

It would help if the nightly builds were triggered on repo changes.
Not blind automatic builds.

Additional info

Update readme.txt with the hash of the repo trigger in the Nightly list.

Activity

  1. justinclift commented on Jun 16, 2019

    @justinclift
    Member

    Agreed. If someone wants to take the time to set up something like CircleCI or similar, that would be really useful. 😄

    Is that your kind of thing to do @sky5walk ?

  2. sky5walk commented on Jun 16, 2019

    @sky5walk
    Author

    Sorry, I just edit batch files for my target OS(Windows) and custom code when necessary.

  3. justinclift commented on Jun 16, 2019

    @justinclift
    Member

    No worries. 😄

  4. karim commented on Jun 17, 2019

    @karim
    Member

    @justinclift I updated Windows build scripts to save, and check, the last build commit and exit the script if there are no new commits. Can you test this to confirm it is working? 😃

  5. justinclift commented on Jun 18, 2019

    @justinclift
    Member

    Oooooh Aaaaaaah, that's pretty cool @karim. 😄

    I'll update the nightly build scripts with that, and run them each twice to see if they work as we want.

  6. justinclift commented on Jun 18, 2019

    @justinclift
    Member

    Yep, that works.

    It needed a slight tweak to run the git rev-parse command from the correct directory, but with that in place it seems good.

    Thanks heaps @karim. 😄

  7. karim commented on Jun 18, 2019

    @karim
    Member

    That's good to hear. 😃

    Sorry, I didn't test the last part where it uploads the file to the server.

    Can we close this issue now or should we give it some time to make sure everything is okay?

  8. justinclift commented on Jun 18, 2019

    @justinclift
    Member

    We should probably get the macOS nightlies doing the same thing first. 😄

  9. Z4us commented on Jun 18, 2019

    @Z4us
  10. sky5walk commented on Jun 18, 2019

    @sky5walk
    Author

    Good deal. Any chance to update the Readme.txt with the repo hash or version string?

  11. 5 remaining items

  12. sky5walk commented on Jun 18, 2019

    @sky5walk
    Author

    I will try when I get some time. Can you send a link to the existing batch file? I browsed a bit, just not sure where is latest. I use Fossil, which has a visual Timeline.

  13. karim commented on Jun 19, 2019

    @karim
    Member

    Batch files used with our nightly builds are here

    These .bat files are not the actual ones that we run on the nightlies server. They are just put there for reference. After any change to them they are copied to the nightlies server and maybe slightly changed to match the build system.

    This commit e26d323, and later corrected by this commit b0bb376 (thanks @justinclift) will show you the current implementation we use.

  14. sky5walk commented on Jul 20, 2019

    @sky5walk
    Author

    As there is no readme update for the nightlies, how can I determine why there is a new nightly for 190719 when the repo says last commit was 7 days ago?

  15. karim commented on Jul 20, 2019

    @karim
    Member

    Both are listing the same hash, from the latest commit 7 days ago, so I'm guessing nothing changed since then. I don't know why there are new builds, we should ask @justinclift about that.

    Maybe he ran the build scripts manually, or something wrong with the build server. Also it seems the win32 build has one more build than the win64.

  16. justinclift commented on Jul 21, 2019

    @justinclift
    Member

    Yeah, I rebuilt them manually a few days ago, after noticing the VM's weren't running on the build box any more (I'd accidentally knocked out the power cable 😦 ). The current physical setup of the build box is a bit precarious at the moment. Can't change it just yet, but it doesn't get disturbed too often so this isn't likely to be repeated much.

  17. sky5walk commented on Jul 21, 2019

    @sky5walk
    Author

    Cool, just verifying no hackaroo's. 😮
    Would be great to have a tiny readme stating whatsup!

  18. justinclift commented on Jul 21, 2019

    @justinclift
    Member

    Hmmm, what would be useful to have in such a readme?

  19. sky5walk commented on Jul 21, 2019

    @sky5walk
    Author

    This allows end users to decide what new changes are in the nightly without browsing the commit tree. It can just regurgitate the commit comment at the top or bottom of the readme or even a new file called reason or commit.
    I do this for my apps to allow end users to decide if they want to upgrade. I keep a version list in a text document on a server. Each paragraph starts with a date based version followed by notes:

    19.07.06
    1) Fixed typo blah blah.
    2) Added amazing feature blah blah.
    19.06.26
    1) Internal fixes and recompiled external lib blah blah.
    
  20. justinclift commented on Jul 21, 2019

    @justinclift
    Member

    Hmmm. So maybe something like?

    $ git log --oneline | head -5
    9fe5297 Allow to change sort order for any column in the multi-column sort list
    592fa91 New function for detecting mixed RTL-LTR texts
    5e965b1 Restore QTextEdit widget for RTL text in the Cell Editor
    786fac0 Updated Italian translation (#1931)
    9594115 Send the fetched signal in RowLoader even when no rows where fetched
    

    Would the optimal thing be to use the commit log (--oneline version) showing the change from the previous build's commit?

  21. sky5walk commented on Jul 21, 2019

    @sky5walk
    Author

    YES! Very nice.
    I would add commit date since it is available and explains to the user at least 5 versions they may have missed. There are other metrics too, like author name, but you can decide how much is necessary.
    git log --oneline | head -5 --format='%cd' --no-merges
    *I did not verify since I use Fossil and don't have git running locally.

  22. mgrojo commented on Oct 5, 2019

    @mgrojo
    Member

    I'd simply do:

    git log %LAST_COMMIT%..HEAD 1> changes-log.txt

    And upload that file to https://nightlies.sqlitebrowser.org/latest/

  23. sky5walk commented on Nov 10, 2019

    @sky5walk
    Author

    Is this broken due to #1959?

  24. MKleusberg commented on Nov 10, 2019

    @MKleusberg
    Member

    Looks like Win32 builds are broken for some time now (just uploading 22 byte files) and Win64 builds might be broken. If so, probably by my recent refactoring commit and some missing include. @justinclift Do you have the time to look at the build log? It should be easy to fix with the error message 😄

  25. SilvioGrosso commented on Nov 10, 2019

    @SilvioGrosso

    IMHO, you should stop releasing the Win32 builds after the upcoming next stable version...

    By doing so you would have only the Win64 builds to take care (and given the recent amount of problems it looks like not an easy task as well).
    On top of that, your servers might be less charged (only one Windows version to handle).

    At present, some open source softwares have already stopped producing them.
    In addition, as an user, you can always download the stable version (with the 32 build available)
    As a developer, you can release every future next stable version as 32 build as well... 😄

  26. sky5walk commented on Nov 15, 2019

    @sky5walk
    Author

    Still not working 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions