You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@justinclift I updated Windows build scripts to save, and check, the last build commit and exit the script if there are no new commits. Can you test this to confirm it is working? 😃
I will try when I get some time. Can you send a link to the existing batch file? I browsed a bit, just not sure where is latest. I use Fossil, which has a visual Timeline.
These .bat files are not the actual ones that we run on the nightlies server. They are just put there for reference. After any change to them they are copied to the nightlies server and maybe slightly changed to match the build system.
This commit e26d323, and later corrected by this commit b0bb376 (thanks @justinclift) will show you the current implementation we use.
As there is no readme update for the nightlies, how can I determine why there is a new nightly for 190719 when the repo says last commit was 7 days ago?
Both are listing the same hash, from the latest commit 7 days ago, so I'm guessing nothing changed since then. I don't know why there are new builds, we should ask @justinclift about that.
Maybe he ran the build scripts manually, or something wrong with the build server. Also it seems the win32 build has one more build than the win64.
Yeah, I rebuilt them manually a few days ago, after noticing the VM's weren't running on the build box any more (I'd accidentally knocked out the power cable 😦 ). The current physical setup of the build box is a bit precarious at the moment. Can't change it just yet, but it doesn't get disturbed too often so this isn't likely to be repeated much.
This allows end users to decide what new changes are in the nightly without browsing the commit tree. It can just regurgitate the commit comment at the top or bottom of the readme or even a new file called reason or commit.
I do this for my apps to allow end users to decide if they want to upgrade. I keep a version list in a text document on a server. Each paragraph starts with a date based version followed by notes:
$ git log --oneline | head -5
9fe5297 Allow to change sort order for any column in the multi-column sort list
592fa91 New function for detecting mixed RTL-LTR texts
5e965b1 Restore QTextEdit widget for RTL text in the Cell Editor
786fac0 Updated Italian translation (#1931)
9594115 Send the fetched signal in RowLoader even when no rows where fetched
Would the optimal thing be to use the commit log (--oneline version) showing the change from the previous build's commit?
YES! Very nice.
I would add commit date since it is available and explains to the user at least 5 versions they may have missed. There are other metrics too, like author name, but you can decide how much is necessary. git log --oneline | head -5 --format='%cd' --no-merges
*I did not verify since I use Fossil and don't have git running locally.
Looks like Win32 builds are broken for some time now (just uploading 22 byte files) and Win64 builds might be broken. If so, probably by my recent refactoring commit and some missing include. @justinclift Do you have the time to look at the build log? It should be easy to fix with the error message 😄
IMHO, you should stop releasing the Win32 builds after the upcoming next stable version...
By doing so you would have only the Win64 builds to take care (and given the recent amount of problems it looks like not an easy task as well).
On top of that, your servers might be less charged (only one Windows version to handle).
At present, some open source softwares have already stopped producing them.
In addition, as an user, you can always download the stable version (with the 32 build available)
As a developer, you can release every future next stable version as 32 build as well... 😄
Activity
justinclift commentedon Jun 16, 2019
Agreed. If someone wants to take the time to set up something like CircleCI or similar, that would be really useful. 😄
Is that your kind of thing to do @sky5walk ?
sky5walk commentedon Jun 16, 2019
Sorry, I just edit batch files for my target OS(Windows) and custom code when necessary.
justinclift commentedon Jun 16, 2019
No worries. 😄
Skip building Windows nightlies if there are no new commits
karim commentedon Jun 17, 2019
@justinclift I updated Windows build scripts to save, and check, the last build commit and exit the script if there are no new commits. Can you test this to confirm it is working? 😃
justinclift commentedon Jun 18, 2019
Oooooh Aaaaaaah, that's pretty cool @karim. 😄
I'll update the nightly build scripts with that, and run them each twice to see if they work as we want.
justinclift commentedon Jun 18, 2019
Yep, that works.
It needed a slight tweak to run the git rev-parse command from the correct directory, but with that in place it seems good.
Thanks heaps @karim. 😄
karim commentedon Jun 18, 2019
That's good to hear. 😃
Sorry, I didn't test the last part where it uploads the file to the server.
Can we close this issue now or should we give it some time to make sure everything is okay?
justinclift commentedon Jun 18, 2019
We should probably get the macOS nightlies doing the same thing first. 😄
Z4us commentedon Jun 18, 2019
sky5walk commentedon Jun 18, 2019
Good deal. Any chance to update the Readme.txt with the repo hash or version string?
5 remaining items
sky5walk commentedon Jun 18, 2019
I will try when I get some time. Can you send a link to the existing batch file? I browsed a bit, just not sure where is latest. I use Fossil, which has a visual Timeline.
karim commentedon Jun 19, 2019
Batch files used with our nightly builds are here
These
.batfiles are not the actual ones that we run on the nightlies server. They are just put there for reference. After any change to them they are copied to the nightlies server and maybe slightly changed to match the build system.This commit e26d323, and later corrected by this commit b0bb376 (thanks @justinclift) will show you the current implementation we use.
sky5walk commentedon Jul 20, 2019
As there is no readme update for the nightlies, how can I determine why there is a new nightly for 190719 when the repo says last commit was 7 days ago?
karim commentedon Jul 20, 2019
Both are listing the same hash, from the latest commit 7 days ago, so I'm guessing nothing changed since then. I don't know why there are new builds, we should ask @justinclift about that.
Maybe he ran the build scripts manually, or something wrong with the build server. Also it seems the win32 build has one more build than the win64.
justinclift commentedon Jul 21, 2019
Yeah, I rebuilt them manually a few days ago, after noticing the VM's weren't running on the build box any more (I'd accidentally knocked out the power cable 😦 ). The current physical setup of the build box is a bit precarious at the moment. Can't change it just yet, but it doesn't get disturbed too often so this isn't likely to be repeated much.
sky5walk commentedon Jul 21, 2019
Cool, just verifying no hackaroo's. 😮
Would be great to have a tiny readme stating whatsup!
justinclift commentedon Jul 21, 2019
Hmmm, what would be useful to have in such a readme?
sky5walk commentedon Jul 21, 2019
This allows end users to decide what new changes are in the nightly without browsing the commit tree. It can just regurgitate the commit comment at the top or bottom of the readme or even a new file called reason or commit.
I do this for my apps to allow end users to decide if they want to upgrade. I keep a version list in a text document on a server. Each paragraph starts with a date based version followed by notes:
justinclift commentedon Jul 21, 2019
Hmmm. So maybe something like?
Would the optimal thing be to use the commit log (
--onelineversion) showing the change from the previous build's commit?sky5walk commentedon Jul 21, 2019
YES! Very nice.
I would add commit date since it is available and explains to the user at least 5 versions they may have missed. There are other metrics too, like author name, but you can decide how much is necessary.
git log --oneline | head -5 --format='%cd' --no-merges*I did not verify since I use Fossil and don't have git running locally.
mgrojo commentedon Oct 5, 2019
I'd simply do:
git log %LAST_COMMIT%..HEAD 1> changes-log.txtAnd upload that file to https://nightlies.sqlitebrowser.org/latest/
sky5walk commentedon Nov 10, 2019
Is this broken due to #1959?
MKleusberg commentedon Nov 10, 2019
Looks like Win32 builds are broken for some time now (just uploading 22 byte files) and Win64 builds might be broken. If so, probably by my recent refactoring commit and some missing include. @justinclift Do you have the time to look at the build log? It should be easy to fix with the error message 😄
SilvioGrosso commentedon Nov 10, 2019
IMHO, you should stop releasing the Win32 builds after the upcoming next stable version...
By doing so you would have only the Win64 builds to take care (and given the recent amount of problems it looks like not an easy task as well).
On top of that, your servers might be less charged (only one Windows version to handle).
At present, some open source softwares have already stopped producing them.
In addition, as an user, you can always download the stable version (with the 32 build available)
As a developer, you can release every future next stable version as 32 build as well... 😄
sky5walk commentedon Nov 15, 2019
Still not working 😭