You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remember user collapse settings of the redundant Execute SQL log.
All its information is already present in the User SQL log.
This frees up more room in the Execute SQL viewshed.
Currently, each new SQL tab recreates 3 evenly spaced gadgets.
User is forced to collapse the Execute SQL log for each new tab. 😞
Additional info
I strongly suggest dropping the Execute SQL log altogether.
Reduce code burden as the information is already piped to the User SQL log.
Is your feature request related to an issue? Please include the issue number.
@sky5walk in the next nightly build, the splitter sizes in the Execute SQL are are saved in the settings. Each time the sppliter are moved, that size is saved for the next tab to be opened. This includes the zero size (collapsed state). Please, give it a try and close this issue if everything works as expected.
Close! But the code does not remember Execute SQL log completely minimized. :(
It replaces full minimize with a consistent skinny height across all open and new tabs.
Again, I would prefer dropping the entire redundant log to avoid this type of nag code support.
By "skinny height" do you mean only the handler? I supose you don't, so I cannot reproduce it in the general case. There is a way to get a default height in the lower splitter: open new tab, move splitter, close, open new one; it gets the default height. It should restore the size of the last moved splitter, but something seems to fails and the default is restored. Is it the same in you case? Maybe Qt is behaving differently due to platform or version difference.
I installed the x64 nightly on Windows 10 Pro.
The "skinny height" means the log has viewable content. No height or fully collapsed is my desire.
Side note: I cannot fully collapse the results window either.
Oh, I see. Thanks for pointing this out, @scottfurry. It worked for a moment even after a restart. Maybe I was fooled by the value saved in the previous change, don't know. But now I see that it behaves erroneously after restart as expected by the actual bad code. In any case, it's better to save to disk only once when closing, so the last commit makes sense.
After mending that, it is working as expected as you already noted. I'll commit the fix.
Activity
Save splitter sizes in the Execute SQL areas
mgrojo commentedon May 17, 2019
@sky5walk in the next nightly build, the splitter sizes in the Execute SQL are are saved in the settings. Each time the sppliter are moved, that size is saved for the next tab to be opened. This includes the zero size (collapsed state). Please, give it a try and close this issue if everything works as expected.
sky5walk commentedon May 17, 2019
Nice! Will all splitter settings be retained, or just the 1 between Execute SQL log and results?
It would be helpful to remember both.
mgrojo commentedon May 18, 2019
Both will be remember: the upper one separating the editor and the table, and the lower one separating the table and the last execution results.
sky5walk commentedon May 18, 2019
Close! But the code does not remember Execute SQL log completely minimized. :(
It replaces full minimize with a consistent skinny height across all open and new tabs.
Again, I would prefer dropping the entire redundant log to avoid this type of nag code support.
mgrojo commentedon May 18, 2019
By "skinny height" do you mean only the handler? I supose you don't, so I cannot reproduce it in the general case. There is a way to get a default height in the lower splitter: open new tab, move splitter, close, open new one; it gets the default height. It should restore the size of the last moved splitter, but something seems to fails and the default is restored. Is it the same in you case? Maybe Qt is behaving differently due to platform or version difference.
sky5walk commentedon May 18, 2019
I installed the x64 nightly on Windows 10 Pro.
The "skinny height" means the log has viewable content. No height or fully collapsed is my desire.
Side note: I cannot fully collapse the results window either.
Save splitter sizes of the Execute SQL areas to disk under request
mgrojo commentedon May 19, 2019
I've fixed the stange behaviour that I was observing. I suppose it is the same issue than yours, @sky5walk and @scottfurry. Could you confirm, please?
sky5walk commentedon May 19, 2019
Is this compiled in the latest nightly?
scottfurry commentedon May 19, 2019
@mgrojo - make one tweak and you might have this one cleaned up
src/SQLExecutionArea.cpp:310
After making that change locally, the 2nd splitter area (log window) was being restored on a restart.
mgrojo commentedon May 19, 2019
Oh, I see. Thanks for pointing this out, @scottfurry. It worked for a moment even after a restart. Maybe I was fooled by the value saved in the previous change, don't know. But now I see that it behaves erroneously after restart as expected by the actual bad code. In any case, it's better to save to disk only once when closing, so the last commit makes sense.
After mending that, it is working as expected as you already noted. I'll commit the fix.
Fix copy-paste-edit error in SqlExecutionArea::saveState()
mgrojo commentedon May 19, 2019
@sky5walk The fix will be included in tomorrow's nightly. I think they are compiled past midnight (UTC).
scottfurry commentedon May 19, 2019
@mgrojo - that looks like it did it. Last fix works for me.
sky5walk commentedon May 20, 2019
Thanks, works great 👍
justinclift commentedon May 21, 2019
Yep. The mac one happens just after midnight, the Win64 one about an hour after, and the Win32 one about an hour after that.