You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the latest nightlies (19 Dec onwards?) the main window can be made smaller than usual. This results in the table combobox becoming quite small and unusable.
We've obviously been playing with different Qt builds, but don't know if this has a bearing on it.
What did you do?
Resized the window
What did you expect to see?
The window wouldn't normally resize beyond a set size
What did you see instead?
The window went smaller than normal. An 'ooh' was expressed.
Useful extra information
The info below often helps, please fill it out if you're able to. :)
This is a consequence of #1678 (better size policy for translations with long texts and not so high resolutions). In order to have wider range for growing and shrinking the docks, the PR set a minimumExpanding policy with a minimum of 50 pixels. I think we can set a maximum, because using so much is useless (I presume nobody has so long table names). But is there really a problem with the minimum? The user can freely make it bigger, so setting a bigger minimum brings no advantage in my opinion. We can ask also @zvova7890 for his opinions on both issues (minimum and maximum).
See also my related PR: #1684, that tries to improve the situation by changing buttons with texts to buttons with icons (among other minor changes). I'd also like to hear your opinions on that.
About minimal size of combobox - before that, you can't make window as small as you do now. So, if it unusable - make window size is a little bigger. About maximum, as for me, it's not a problem... and as i known sqlite table names has no limitation for length.
@chrisjlocke PR #1684 is merged and now the table combo-box does not shrink beyond a certain width, while the window size can still be adjusted with enough freedom.
Hey, come on ... a six month response time is pretty good! ;)
Yes, the minimised combobox has been corrected, and I /was/ going to say the combobox is still small as before...
Makes identifying tables difficult ... BUT that's due to my screen layout. Texts in the icons, and edit database cell window on the right. Sort that out, and the combobox does indeed stretch out... but not by a stupid amount anymore...
After six months (why does a change take this long to implement???!!!! 😉 😉 ) I can close this. ❤️ Thanks guys!
Activity
chrisjlocke commentedon Dec 24, 2018
The combobox also now 'fills the space'. So before:
and now:
not a major problem, but its a bit big if you go full screen!
justinclift commentedon Dec 24, 2018
Guessing here, but kind of thinking it's probably a side effect of the in-progress changes being done for #1675.
It's good to mention them, so @mgrojo is aware of the changes as the experimentation progresses. 😄
chrisjlocke commentedon Dec 24, 2018
Indeed. Presumed it was related to the Qt kerfuffles.... just seems a weird side effect.
mgrojo commentedon Dec 24, 2018
This is a consequence of #1678 (better size policy for translations with long texts and not so high resolutions). In order to have wider range for growing and shrinking the docks, the PR set a minimumExpanding policy with a minimum of 50 pixels. I think we can set a maximum, because using so much is useless (I presume nobody has so long table names). But is there really a problem with the minimum? The user can freely make it bigger, so setting a bigger minimum brings no advantage in my opinion. We can ask also @zvova7890 for his opinions on both issues (minimum and maximum).
See also my related PR: #1684, that tries to improve the situation by changing buttons with texts to buttons with icons (among other minor changes). I'd also like to hear your opinions on that.
zvova7890 commentedon Dec 24, 2018
About minimal size of combobox - before that, you can't make window as small as you do now. So, if it unusable - make window size is a little bigger. About maximum, as for me, it's not a problem... and as i known sqlite table names has no limitation for length.
mgrojo commentedon Feb 9, 2019
@chrisjlocke PR #1684 is merged and now the table combo-box does not shrink beyond a certain width, while the window size can still be adjusted with enough freedom.
chrisjlocke commentedon Feb 10, 2019
Will check that tomorrow - thanks!
MKleusberg commentedon Feb 12, 2020
@chrisjlocke Did you check it 'tomorrow'? 😛
mgrojo commentedon Aug 12, 2020
@chrisjlocke ping 😄
chrisjlocke commentedon Aug 13, 2020
Hey, come on ... a six month response time is pretty good! ;)
Yes, the minimised combobox has been corrected, and I /was/ going to say the combobox is still small as before...
Makes identifying tables difficult ... BUT that's due to my screen layout. Texts in the icons, and edit database cell window on the right. Sort that out, and the combobox does indeed stretch out... but not by a stupid amount anymore...
After six months (why does a change take this long to implement???!!!! 😉 😉 ) I can close this. ❤️ Thanks guys!