Skip to content

Main window minimum window size reduced #1685

Closed

Description

@chrisjlocke

Details for the issue

With the latest nightlies (19 Dec onwards?) the main window can be made smaller than usual. This results in the table combobox becoming quite small and unusable.

image

We've obviously been playing with different Qt builds, but don't know if this has a bearing on it.

What did you do?

Resized the window

What did you expect to see?

The window wouldn't normally resize beyond a set size

image

What did you see instead?

The window went smaller than normal. An 'ooh' was expressed.

image

Useful extra information

The info below often helps, please fill it out if you're able to. :)

What operating system are you using?

  • Windows: ( version: 10_ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

What is your DB4S version?

Nightly (24 Dec)

  • 3.11.0-alpha1 or 3.11.0-beta*
  • 3.10.1
  • Other: ___

Did you also

Activity

  1. chrisjlocke commented on Dec 24, 2018

    @chrisjlocke
    MemberAuthor

    The combobox also now 'fills the space'. So before:

    image

    and now:

    image

    not a major problem, but its a bit big if you go full screen!

    image

  2. justinclift commented on Dec 24, 2018

    @justinclift
    Member

    Guessing here, but kind of thinking it's probably a side effect of the in-progress changes being done for #1675.

    It's good to mention them, so @mgrojo is aware of the changes as the experimentation progresses. 😄

  3. chrisjlocke commented on Dec 24, 2018

    @chrisjlocke
    MemberAuthor

    Indeed. Presumed it was related to the Qt kerfuffles.... just seems a weird side effect.

  4. mgrojo commented on Dec 24, 2018

    @mgrojo
    Member

    This is a consequence of #1678 (better size policy for translations with long texts and not so high resolutions). In order to have wider range for growing and shrinking the docks, the PR set a minimumExpanding policy with a minimum of 50 pixels. I think we can set a maximum, because using so much is useless (I presume nobody has so long table names). But is there really a problem with the minimum? The user can freely make it bigger, so setting a bigger minimum brings no advantage in my opinion. We can ask also @zvova7890 for his opinions on both issues (minimum and maximum).

    See also my related PR: #1684, that tries to improve the situation by changing buttons with texts to buttons with icons (among other minor changes). I'd also like to hear your opinions on that.

  5. zvova7890 commented on Dec 24, 2018

    @zvova7890
    Contributor

    About minimal size of combobox - before that, you can't make window as small as you do now. So, if it unusable - make window size is a little bigger. About maximum, as for me, it's not a problem... and as i known sqlite table names has no limitation for length.

  6. mgrojo commented on Feb 9, 2019

    @mgrojo
    Member

    @chrisjlocke PR #1684 is merged and now the table combo-box does not shrink beyond a certain width, while the window size can still be adjusted with enough freedom.

  7. chrisjlocke commented on Feb 10, 2019

    @chrisjlocke
    MemberAuthor

    Will check that tomorrow - thanks!

  8. MKleusberg commented on Feb 12, 2020

    @MKleusberg
    Member

    @chrisjlocke Did you check it 'tomorrow'? 😛

  9. mgrojo commented on Aug 12, 2020

    @mgrojo
    Member

    @chrisjlocke ping 😄

  10. chrisjlocke commented on Aug 13, 2020

    @chrisjlocke
    MemberAuthor

    Hey, come on ... a six month response time is pretty good! ;)
    Yes, the minimised combobox has been corrected, and I /was/ going to say the combobox is still small as before...

    image

    Makes identifying tables difficult ... BUT that's due to my screen layout. Texts in the icons, and edit database cell window on the right. Sort that out, and the combobox does indeed stretch out... but not by a stupid amount anymore...

    image

    After six months (why does a change take this long to implement???!!!! 😉 😉 ) I can close this. ❤️ Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions