You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Table->Modify. No changes,direct cancel raises error #1547
I think it's better to keep it as an enhancement. You are right, it should say the user what happens. And maybe it should say it before trying to perform any change in the database, otherwise it will fail on Ok or Cancel, without being our fault.
I made a change. It can actually be considered a bug, because the message from the database engine that we were displaying wasn't actually from this check, but from other previous operation.
I've also put two different messages for the case of accepting changes or cancelling them. In the second case we know for sure that our changes are not the reason for the failing check, so we warn the user to fix the problem himself.
This table did not pass a foreign-key check.
You should run 'Tools | Foreign-Key Check' and fix the reported issues.
Have you a copy of the database for confirming tomorrow that it's working for you as well? Otherwise, if you're interested, you can disable foreign keys in the pragmas tab, make some insertion incoherent to the foreign keys, and then reenable the foreign key. Then you can reproduce the same situation.
There is also room for improvement: maybe the check should be done before opening the
dialog, so we don't let the user edit the table until the issues have
been solved. But I don't want to add a penalty for big databases by performing two checks, one before and other after; and I don't dare to change that now, since we plan to release soon and that may break anything if I overlook something.
I can confirm the new clarifying message on 'Cancel'. Good to the point message and call to action.
Thanks!
Without knowing, my database has been "corrupt" (albeit benign) for quite some time without knowing. The check tools weren't around last time I used SB, so these are quite good new features.
Would it be an idea to add some option for a 'health' check on database save. E.g. a popup asking whether a check should be run before saving? In preferences it could be set as 'never', 'always', 'ask'
Would it be an idea to add some option for a 'health' check on database save. E.g. a popup asking whether a check should be run before saving? In preferences it could be set as 'never', 'always', 'ask'
Yes, it might be helpful. But we won't see it in the near time, since we want to close all the relevant pending issues and freeze the interface texts for translation. Would you mind opening an enhancement request with the idea so it is not forgotten?
Activity
mgrojo commentedon Sep 29, 2018
I cannot reproduce it with my database files. What are the different check options in the Tools menu saying about this database?
pamtbaau commentedon Sep 29, 2018
Ah...
PRAGMA foreign_key_check;returned a tuple in one of my tables. Foreign Key on that tuple is indeed invalid.Never used these checks in the Tools menu before...
Maybe showing the result of the foreign key check on 'Cancel' might clarify a lot to the user...
I guess the issue may be closed.
mgrojo commentedon Sep 29, 2018
I think it's better to keep it as an enhancement. You are right, it should say the user what happens. And maybe it should say it before trying to perform any change in the database, otherwise it will fail on Ok or Cancel, without being our fault.
Better messages for a table edition when foreign-key check detect pro…
mgrojo commentedon Sep 29, 2018
I made a change. It can actually be considered a bug, because the message from the database engine that we were displaying wasn't actually from this check, but from other previous operation.
I've also put two different messages for the case of accepting changes or cancelling them. In the second case we know for sure that our changes are not the reason for the failing check, so we warn the user to fix the problem himself.
Have you a copy of the database for confirming tomorrow that it's working for you as well? Otherwise, if you're interested, you can disable foreign keys in the pragmas tab, make some insertion incoherent to the foreign keys, and then reenable the foreign key. Then you can reproduce the same situation.
There is also room for improvement: maybe the check should be done before opening the
dialog, so we don't let the user edit the table until the issues have
been solved. But I don't want to add a penalty for big databases by performing two checks, one before and other after; and I don't dare to change that now, since we plan to release soon and that may break anything if I overlook something.
pamtbaau commentedon Sep 30, 2018
I can confirm the new clarifying message on 'Cancel'. Good to the point message and call to action.
Thanks!
Without knowing, my database has been "corrupt" (albeit benign) for quite some time without knowing. The check tools weren't around last time I used SB, so these are quite good new features.
Would it be an idea to add some option for a 'health' check on database save. E.g. a popup asking whether a check should be run before saving? In preferences it could be set as 'never', 'always', 'ask'
mgrojo commentedon Sep 30, 2018
Yes, it might be helpful. But we won't see it in the near time, since we want to close all the relevant pending issues and freeze the interface texts for translation. Would you mind opening an enhancement request with the idea so it is not forgotten?