You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
yeah, I've tried nightly builds before, but I didn't find this option.
and still can't find it...
should I use a dark theme for my windows to get this feature?
Yes, @khashayarxy It follows the theme configured in the operating system. Remember also to "Restore Defaults" in Preferences for the editor to get appropriate colours for the theme.
Is it feasible to have a toggle or selection to switch between light/dark theme?
If we are talking about the SQL editor, it would be feasible to have a combo box for selecting the light or the dark theme. That would allow the users to change the editor colours without restoring defaults.
But I'm unsure about the Qt widgets. They generally follow the desktop theme, as everyone would expect.
I wanted something like this so that I don't have to do that.
What is what you wouldn't like to do? Restoring the defaults or applying a dark theme to all the system?
Ahhh. Most applications that support dark and light themes seem to have either a toggle or selector. When the user makes a change of the appropriate button or selector, the theme for the entire app changes to light or dark (as selected). That's what @khashayarxy was likely meaning.
Saying that because I often use dark mode in applications, and that's the way I've generally seen it done.
Our current approach does work, but it has the downside of also resetting all of a users other settings too, not just adjusting the theme. It might be better to break out the theme adjustment into it's own button or something anyway, just to avoid resetting everything else too. 😄
Most applications that support dark and light themes seem to have either a toggle or selector.
But probably they don't have then options for every possible colour, like we have for the editor. That adds complexity for the settings management.
By the way, in the Linux desktop the theme is usually selected centrally. I find that the sanest approach, although one can find application that doesn't look good in dark themes.
Our current approach does work, but it has the downside of also resetting all of a users other settings too, not just adjusting the theme.
If we didn't let the user modify the editor colours, then it would be easy to follow the system theme without restoring the defaults. But I guess that wouldn't be very welcome.
But probably they don't have then options for every possible colour, like we have for the editor.
Hmmm, the JetBrains IDE's do. But yeah, that's a good point. Hadn't thought of that.
I wonder if the solution would be to have the colours be stored "per profile"? eg a "Dark" profile, and if the user edits the colours then they only affect that one.
If they switch to a (for example) "light" profile afterwards that hasn't been edited, it'd just be the default "light" profile colours. If they change those ones, the changes get kept for the light profile only.
That way a user can have both dark and light themes, and be able to tweak them to suit. For bonus points we could probably add some way to create extra profile/themes too.
@voltagex I have the latest build of Windows 10 and that Dark/Light mode is just for settings and doesn't affect applications or Windows itself. You should change the theme of Windows to see the change.
@sky5walk The filter row is moved programmatically. In my last commit (baaeea8) I hope to have fixed both your issue and mine in a portable way. I still think they have the same cause, the new y coordinate is calculated incorrectly. The original code seemed to assume that the filter row height and the original table header height (without filter row) were equal.
I'll try to find time for the font problem in the following days.
Ok, 190304 fixes the Filter row alignment. Dark mode is almost ready.
BUGS:
Cell editor has no means to alter foreground/background colors in dark mode.
All contents invisible without select all.
Editing color preferences dialog background takes the last chosen color.
Color dialog becomes obscured by the changing color patterns of each selection.
Font name and size changes to some smaller default when toggling back to "follow desktop" mode.
Thanks!
I guess #3. depends if you changed the default font name and size?
I set mine to Consolas 12 since I want a fixed pitch font that shows 0(with a slash inside) different from O.
Nightly v190311 fixes my issues with Dark Theme while on Windows 10 Pro. 👍
The Scintilla gadget used for the cell editor now respects Dark Theme and the text is visible.
Oh, it might have been the refactor that I made for loading the settings for QScintilla widgets in #1793. Nice to know. The QScintilla's behaviour regarding this is certainly convoluted.
Any suggestions for a build that has this feature and is also known to be stable? On Ubuntu 20.04 this feature is not yet part of the latest package available via apt, and I'd rather not fetch a new nightly build every time my system upgrades its packages by adding the nightly PPA.
Activity
justinclift commentedon Aug 5, 2018
Good news @khashayarxy. Support for a dark mode / night theme type of thing was added a while ago by @mgrojo, in #1324.
If you're on macOS, Windows, or Ubuntu, it's in our nightly builds:
https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
Would you be ok to try that out and let us know how it goes for you? 😄
khashayarxy commentedon Aug 5, 2018
yeah, I've tried nightly builds before, but I didn't find this option.
and still can't find it...
should I use a dark theme for my windows to get this feature?
mgrojo commentedon Aug 5, 2018
Yes, @khashayarxy It follows the theme configured in the operating system. Remember also to "Restore Defaults" in Preferences for the editor to get appropriate colours for the theme.
khashayarxy commentedon Aug 5, 2018
I wanted something like this so that I don't have to do that.

justinclift commentedon Aug 6, 2018
Hmmm, yeah. That does sound like a better approach.
@mgrojo Is it feasible to have a toggle or selection to switch between light/dark theme?
mgrojo commentedon Aug 6, 2018
But I'm unsure about the Qt widgets. They generally follow the desktop theme, as everyone would expect.
What is what you wouldn't like to do? Restoring the defaults or applying a dark theme to all the system?
justinclift commentedon Aug 6, 2018
Ahhh. Most applications that support dark and light themes seem to have either a toggle or selector. When the user makes a change of the appropriate button or selector, the theme for the entire app changes to light or dark (as selected). That's what @khashayarxy was likely meaning.
Saying that because I often use dark mode in applications, and that's the way I've generally seen it done.
Our current approach does work, but it has the downside of also resetting all of a users other settings too, not just adjusting the theme. It might be better to break out the theme adjustment into it's own button or something anyway, just to avoid resetting everything else too. 😄
khashayarxy commentedon Aug 6, 2018
@mgrojo
Applying a dark theme to all the system
@justinclift
That is exactly my point.
mgrojo commentedon Aug 6, 2018
But probably they don't have then options for every possible colour, like we have for the editor. That adds complexity for the settings management.
By the way, in the Linux desktop the theme is usually selected centrally. I find that the sanest approach, although one can find application that doesn't look good in dark themes.
If we didn't let the user modify the editor colours, then it would be easy to follow the system theme without restoring the defaults. But I guess that wouldn't be very welcome.
khashayarxy commentedon Aug 6, 2018
@mgrojo
Well, we can use this idea of having light and dark theme only in the official release.
This way everyone is happy.
justinclift commentedon Aug 6, 2018
Hmmm, the JetBrains IDE's do. But yeah, that's a good point. Hadn't thought of that.
I wonder if the solution would be to have the colours be stored "per profile"? eg a "Dark" profile, and if the user edits the colours then they only affect that one.
If they switch to a (for example) "light" profile afterwards that hasn't been edited, it'd just be the default "light" profile colours. If they change those ones, the changes get kept for the light profile only.
That way a user can have both dark and light themes, and be able to tweak them to suit. For bonus points we could probably add some way to create extra profile/themes too.
mgrojo commentedon Aug 10, 2018
@voltagex Is the application still in a ligth mode, or is only some widgets? Could you publish a screenshot?
khashayarxy commentedon Aug 10, 2018
@voltagex I have the latest build of Windows 10 and that Dark/Light mode is just for settings and doesn't affect applications or Windows itself. You should change the theme of Windows to see the change.
62 remaining items
Fix table header issues in a more portable way
mgrojo commentedon Mar 3, 2019
@sky5walk The filter row is moved programmatically. In my last commit (baaeea8) I hope to have fixed both your issue and mine in a portable way. I still think they have the same cause, the new y coordinate is calculated incorrectly. The original code seemed to assume that the filter row height and the original table header height (without filter row) were equal.
I'll try to find time for the font problem in the following days.
sky5walk commentedon Mar 4, 2019
Ok, 190304 fixes the Filter row alignment. Dark mode is almost ready.
BUGS:
All contents invisible without select all.
Color dialog becomes obscured by the changing color patterns of each selection.
Removed code for changing the default Qt behaviour for read-only+sele…
Avoid style-sheet inheritance in colour chooser boxes in Preferences
mgrojo commentedon Mar 4, 2019
@sky5walk
sky5walk commentedon Mar 4, 2019
Thanks!
I guess #3. depends if you changed the default font name and size?
I set mine to Consolas 12 since I want a fixed pitch font that shows 0(with a slash inside) different from O.
sky5walk commentedon Mar 11, 2019
Nightly v190311 fixes my issues with Dark Theme while on Windows 10 Pro. 👍
The Scintilla gadget used for the cell editor now respects Dark Theme and the text is visible.
mgrojo commentedon Mar 11, 2019
Oh, it might have been the refactor that I made for loading the settings for QScintilla widgets in #1793. Nice to know. The QScintilla's behaviour regarding this is certainly convoluted.
mgrojo commentedon Mar 11, 2019
Anyone having problems with the new Dark style preference? Any maOS user? Maybe we can close this, if nobody is having problems.
justinclift commentedon Mar 23, 2019
Closing this now. If it turns out to not be working ok, people are welcome to reopen it. 😄
matanox commentedon Dec 12, 2020
Any suggestions for a build that has this feature and is also known to be stable? On Ubuntu 20.04 this feature is not yet part of the latest package available via apt, and I'd rather not fetch a new nightly build every time my system upgrades its packages by adding the nightly PPA.
mgrojo commentedon Dec 18, 2020
@matanster Another option for you is the AppImage of the continuous build: https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/continuous