Skip to content

Night Mode or Dark Theme #1493

Closed
Closed

Description

@khashayarxy

Describe the new feature

Night Mode or Dark Theme
it would be great if you add this and I think many people want it.

Activity

  1. justinclift commented on Aug 5, 2018

    @justinclift
    Member

    Good news @khashayarxy. Support for a dark mode / night theme type of thing was added a while ago by @mgrojo, in #1324.

    If you're on macOS, Windows, or Ubuntu, it's in our nightly builds:

        https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds

    Would you be ok to try that out and let us know how it goes for you? 😄

  2. khashayarxy commented on Aug 5, 2018

    @khashayarxy
    Author

    yeah, I've tried nightly builds before, but I didn't find this option.
    and still can't find it...
    should I use a dark theme for my windows to get this feature?

  3. mgrojo commented on Aug 5, 2018

    @mgrojo
    Member

    Yes, @khashayarxy It follows the theme configured in the operating system. Remember also to "Restore Defaults" in Preferences for the editor to get appropriate colours for the theme.

  4. khashayarxy commented on Aug 5, 2018

    @khashayarxy
    Author

    I wanted something like this so that I don't have to do that.
    officetheme

  5. justinclift commented on Aug 6, 2018

    @justinclift
    Member

    Hmmm, yeah. That does sound like a better approach.

    @mgrojo Is it feasible to have a toggle or selection to switch between light/dark theme?

  6. mgrojo commented on Aug 6, 2018

    @mgrojo
    Member

    Is it feasible to have a toggle or selection to switch between light/dark theme?
    If we are talking about the SQL editor, it would be feasible to have a combo box for selecting the light or the dark theme. That would allow the users to change the editor colours without restoring defaults.

    But I'm unsure about the Qt widgets. They generally follow the desktop theme, as everyone would expect.

    I wanted something like this so that I don't have to do that.

    What is what you wouldn't like to do? Restoring the defaults or applying a dark theme to all the system?

  7. justinclift commented on Aug 6, 2018

    @justinclift
    Member

    Ahhh. Most applications that support dark and light themes seem to have either a toggle or selector. When the user makes a change of the appropriate button or selector, the theme for the entire app changes to light or dark (as selected). That's what @khashayarxy was likely meaning.

    Saying that because I often use dark mode in applications, and that's the way I've generally seen it done.

    Our current approach does work, but it has the downside of also resetting all of a users other settings too, not just adjusting the theme. It might be better to break out the theme adjustment into it's own button or something anyway, just to avoid resetting everything else too. 😄

  8. khashayarxy commented on Aug 6, 2018

    @khashayarxy
    Author

    @mgrojo
    Applying a dark theme to all the system

    @justinclift
    That is exactly my point.

  9. mgrojo commented on Aug 6, 2018

    @mgrojo
    Member

    Most applications that support dark and light themes seem to have either a toggle or selector.

    But probably they don't have then options for every possible colour, like we have for the editor. That adds complexity for the settings management.

    By the way, in the Linux desktop the theme is usually selected centrally. I find that the sanest approach, although one can find application that doesn't look good in dark themes.

    Our current approach does work, but it has the downside of also resetting all of a users other settings too, not just adjusting the theme.

    If we didn't let the user modify the editor colours, then it would be easy to follow the system theme without restoring the defaults. But I guess that wouldn't be very welcome.

  10. khashayarxy commented on Aug 6, 2018

    @khashayarxy
    Author

    @mgrojo
    Well, we can use this idea of having light and dark theme only in the official release.
    This way everyone is happy.

  11. justinclift commented on Aug 6, 2018

    @justinclift
    Member

    But probably they don't have then options for every possible colour, like we have for the editor.

    Hmmm, the JetBrains IDE's do. But yeah, that's a good point. Hadn't thought of that.

    I wonder if the solution would be to have the colours be stored "per profile"? eg a "Dark" profile, and if the user edits the colours then they only affect that one.

    If they switch to a (for example) "light" profile afterwards that hasn't been edited, it'd just be the default "light" profile colours. If they change those ones, the changes get kept for the light profile only.

    That way a user can have both dark and light themes, and be able to tweak them to suit. For bonus points we could probably add some way to create extra profile/themes too.

  12. mgrojo commented on Aug 10, 2018

    @mgrojo
    Member

    @voltagex Is the application still in a ligth mode, or is only some widgets? Could you publish a screenshot?

  13. khashayarxy commented on Aug 10, 2018

    @khashayarxy
    Author

    @voltagex I have the latest build of Windows 10 and that Dark/Light mode is just for settings and doesn't affect applications or Windows itself. You should change the theme of Windows to see the change.

  14. 62 remaining items

  15. mgrojo commented on Mar 3, 2019

    @mgrojo
    Member

    @sky5walk The filter row is moved programmatically. In my last commit (baaeea8) I hope to have fixed both your issue and mine in a portable way. I still think they have the same cause, the new y coordinate is calculated incorrectly. The original code seemed to assume that the filter row height and the original table header height (without filter row) were equal.

    I'll try to find time for the font problem in the following days.

  16. sky5walk commented on Mar 4, 2019

    @sky5walk

    Ok, 190304 fixes the Filter row alignment. Dark mode is almost ready.
    BUGS:

    1. Cell editor has no means to alter foreground/background colors in dark mode.
      All contents invisible without select all.
    2. Editing color preferences dialog background takes the last chosen color.
      Color dialog becomes obscured by the changing color patterns of each selection.
    3. Font name and size changes to some smaller default when toggling back to "follow desktop" mode.
  17. mgrojo commented on Mar 4, 2019

    @mgrojo
    Member

    @sky5walk

    1. Should be solved.
    2. Might be solved, but it isn't happening to me, so I tried to fix it blindly.
    3. Not yet analysed, but I think it isn't happening to me either.
  18. sky5walk commented on Mar 4, 2019

    @sky5walk

    Thanks!
    I guess #3. depends if you changed the default font name and size?
    I set mine to Consolas 12 since I want a fixed pitch font that shows 0(with a slash inside) different from O.

  19. sky5walk commented on Mar 11, 2019

    @sky5walk

    Nightly v190311 fixes my issues with Dark Theme while on Windows 10 Pro. 👍
    The Scintilla gadget used for the cell editor now respects Dark Theme and the text is visible.

  20. mgrojo commented on Mar 11, 2019

    @mgrojo
    Member

    Oh, it might have been the refactor that I made for loading the settings for QScintilla widgets in #1793. Nice to know. The QScintilla's behaviour regarding this is certainly convoluted.

  21. mgrojo commented on Mar 11, 2019

    @mgrojo
    Member

    Anyone having problems with the new Dark style preference? Any maOS user? Maybe we can close this, if nobody is having problems.

  22. justinclift commented on Mar 23, 2019

    @justinclift
    Member

    Closing this now. If it turns out to not be working ok, people are welcome to reopen it. 😄

  23. matanox commented on Dec 12, 2020

    @matanox

    Any suggestions for a build that has this feature and is also known to be stable? On Ubuntu 20.04 this feature is not yet part of the latest package available via apt, and I'd rather not fetch a new nightly build every time my system upgrades its packages by adding the nightly PPA.

  24. mgrojo commented on Dec 18, 2020

    @mgrojo
    Member

    @matanster Another option for you is the AppImage of the continuous build: https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/continuous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions