You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The installer is run with the /q (or /s?) switch to make it silent. If that switch is removed, we might get an idea of whats going on?
I'd assume it might show what its doing?
Actually, I think we should move from NSIS and create a MSI installer instead. It is being requested a lot.
I started doing that a few days ago and I'm almost finished. I'm not doing it with CPack WIX, but using WiX Toolset. I should be making a PR in a couple of hours (after doing some tests) or tomorrow.
Good thing about MSI is that VCRedist is bundled with it (as a merge module) and we no longer need to include vcredist.exe anymore. Also we no longer need to include/run winlaunch.bat after setup to launch the application in the context of the current user (not admin), since MSI can do that automatically.
@justinclift You should download WiX Toolset and install it on the build machine so we can start building .msi installers.
Looking into some log files which @JReally has kindly emailed me for an installation run which hangs.
The log file itself is pretty short. These two lines in it seem to confirm the hang and indicate a potential source of the problem:
[154C:1470][2018-05-31T10:29:00]i300: Apply begin
[0F60:1050][2018-05-31T10:35:06]w308: Automatic updates could not be paused due to error: 0x80080005. Continuing...
Note the timestamp in the 2nd column, showing a delay of 6 minutes and 5 seconds between those two entries. It looks like a timeout failure of some variety happened, which generates that error.
Doing some searching online for that error code, it seems like an issue with Windows update. I've asked @JReally if the Windows Update service is disabled or otherwise customised.
Kind of hoping that's the case as that'd mean we've figured out the right area to look into.
Oh... I wonder if the problem might also be a network layer thing. Maybe caused by Windows Update trying to talk to the MS update servers (or similar), and being blocked + timing out by the network in use. eg something like a firewall rule blocking updates
Ok, it's definitely 4th June when downloaded and installed on a different PC as well. It's definitely looking like the one on the server itself is ok. *whew*
All good... sorry about this. Not sure that I can identify exactly what happened. Before I reported it, I was fairly sure I had deleted all previous references and retested... obviously I missed something. I did jump on the downloads (originally) literally moments after Justin had set the June 4 version on-line. I downloaded a fresh copy for the latest test... so was there some cache issue? who knows.
Items 1, 9, 13, 16 stand out to me. After I get today's .msi weirdness solved, I'll update the SQLite version on the build server so tomorrow's SQLite specific builds include that.
Interestingly, when I manually launch winbuild.bat, the .msi files are built fine. However, when its' launched from Task Scheduler the .msi files don't build.
Managed to capture an error message from the Wix bits, which should help track down the problem:
light.exe : error LGHT0217 : Error executing ICE action 'ICE01'. The most common cause of this kind of ICE failure is an incorrectly registered scripting engine. See http://wixtoolset.org/documentation/error217/ for details and how to solve this problem. The following string format was not expected by the external UI message logger: "The Windows Installer Service could not be accessed. This can occur if the Windows Installer is not correctly installed. Contact your support personnel for assistance.".
light.exe : error LGHT0217 : Error executing ICE action 'ICE02'. The most common cause of this kind of ICE failure is an incorrectly registered scripting engine. See http://wixtoolset.org/documentation/error217/ for details and how to solve this problem. The following string format was not expected by the external UI message logger: "The Windows Installer Service could not be accessed. This can occur if the Windows Installer is not correctly installed. Contact your support personnel for assistance.".
light.exe : error LGHT0217 : Error executing ICE action 'ICE04'. The most common cause of this kind of ICE failure is an incorrectly registered scripting engine. See http://wixtoolset.org/documentation/error217/ for details and how to solve this problem. The following string format was not expected by the external UI message logger: "The Windows Installer Service could not be accessed. This can occur if the Windows Installer is not correctly installed. Contact your support personnel for assistance.".
light.exe : error LGHT0217 : Error executing ICE action 'ICE05'. The most common cause of this kind of ICE failure is an incorrectly registered scripting engine. See http://wixtoolset.org/documentation/error217/ for details and how to solve this problem. The following string format was not expected by the external UI message logger: "The Windows Installer Service could not be accessed. This can occur if the Windows Installer is not correctly installed. Contact your support personnel for assistance.".
light.exe : error LGHT0217 : Error executing ICE action 'ICE06'. The most common cause of this kind of ICE failure is an incorrectly registered scripting engine. See http://wixtoolset.org/documentation/error217/ for details and how to solve this problem. The following string format was not expected by the external UI message logger: "The Windows Installer Service could not be accessed. This can occur if the Windows Installer is not correctly installed. Contact your support personnel for assistance.".
light.exe : error LGHT0217 : Error executing ICE action 'ICE07'. The most common cause of this kind of ICE failure is an incorrectly registered scripting engine. See http://wixtoolset.org/documentation/error217/ for details and how to solve this problem. The following string format was not expected by the external UI message logger: "The Windows Installer Service could not be accessed. This can occur if the Windows Installer is not correctly installed. Contact your support personnel for assistance.".
light.exe : error LGHT0216 : An unexpected Win32 exception with error code 0x643 occurred: Action - 'ICE09' Fatal error during installation
Closing this, as the new MSI based installers shouldn't be able to hang, and we're also providing .zip based ones now too. eg unzip it and people are ready to go.
If that hangs, then there's something really, really wrong. 😉
Activity
justinclift commentedon May 30, 2018
As a data point, several people that experience this hanging behaviour are sharing useful info in the original GitHub repo issue this was reported in.
chrisjlocke commentedon May 30, 2018
The installer is run with the /q (or /s?) switch to make it silent. If that switch is removed, we might get an idea of whats going on?
I'd assume it might show what its doing?
justinclift commentedon May 30, 2018
Good point. We could make a debugging build for people to try, and see if anything useful shows up.
justinclift commentedon May 30, 2018
This is the line that launches the command:
sqlitebrowser/CMakeLists.txt
Line 519 in 39302f5
I'll start a build without the
/quietoption in a minute, and point people at it. 😄justinclift commentedon May 30, 2018
Ahhh, looks like we should turn off
/passivetoo for this exercise.It's building now...
justinclift commentedon May 30, 2018
Ahhh, it can also take a
/log log.txtoption.Probably best to include that as well.
karim commentedon May 30, 2018
Actually, I think we should move from NSIS and create a MSI installer instead. It is being requested a lot.
I started doing that a few days ago and I'm almost finished. I'm not doing it with CPack WIX, but using WiX Toolset. I should be making a PR in a couple of hours (after doing some tests) or tomorrow.
Good thing about MSI is that VCRedist is bundled with it (as a merge module) and we no longer need to include vcredist.exe anymore. Also we no longer need to include/run
winlaunch.batafter setup to launch the application in the context of the current user (not admin), since MSI can do that automatically.@justinclift You should download WiX Toolset and install it on the build machine so we can start building
.msiinstallers.justinclift commentedon May 30, 2018
Cool. CPack is a major pain. 😄
justinclift commentedon May 30, 2018
WiX Toolset v3.11.1 is now installed on the Windows build box.
karim commentedon May 30, 2018
Very good. I should make a PR soon.
justinclift commentedon May 31, 2018
Looking into some log files which @JReally has kindly emailed me for an installation run which hangs.
The log file itself is pretty short. These two lines in it seem to confirm the hang and indicate a potential source of the problem:
Note the timestamp in the 2nd column, showing a delay of 6 minutes and 5 seconds between those two entries. It looks like a timeout failure of some variety happened, which generates that error.
Doing some searching online for that error code, it seems like an issue with Windows update. I've asked @JReally if the Windows Update service is disabled or otherwise customised.
Kind of hoping that's the case as that'd mean we've figured out the right area to look into.
Oh... I wonder if the problem might also be a network layer thing. Maybe caused by Windows Update trying to talk to the MS update servers (or similar), and being blocked + timing out by the network in use. eg something like a firewall rule blocking updates
justinclift commentedon May 31, 2018
Relevant StackOverflow error, from someone else having the same problem:
It does seem to be Windows Update related.
29 remaining items
JReally commentedon Jun 4, 2018
OK... I'll start over. I had already previously uninstalled (manually) and removed all related folders. Here I go again! I'll report back.
justinclift commentedon Jun 4, 2018
No worries. 😄
@karim added a commit earlier today (captured in these builds) which automatically adds a desktop shortcut too.
Might be useful to try launching it from that too, just to see if a different version of it somehow launches using your normal launch approach. 😄
justinclift commentedon Jun 4, 2018
Ok, it's definitely 4th June when downloaded and installed on a different PC as well. It's definitely looking like the one on the server itself is ok. *whew*
JReally commentedon Jun 4, 2018
All good... sorry about this. Not sure that I can identify exactly what happened. Before I reported it, I was fairly sure I had deleted all previous references and retested... obviously I missed something. I did jump on the downloads (originally) literally moments after Justin had set the June 4 version on-line. I downloaded a fresh copy for the latest test... so was there some cache issue? who knows.
justinclift commentedon Jun 4, 2018
No worries at all @JReally. It's good when problems turn out to be simple to fix. 😄
justinclift commentedon Jun 5, 2018
Hmmm, the nightly build script make the .exe's fine last night, but the .msi's aren't there.
Investigating again...
justinclift commentedon Jun 5, 2018
On a related note, SQLite 3.24.0 was released a few days ago and looks like it has useful things included:
http://sqlite.org/releaselog/3_24_0.html
Items 1, 9, 13, 16 stand out to me. After I get today's .msi weirdness solved, I'll update the SQLite version on the build server so tomorrow's SQLite specific builds include that.
justinclift commentedon Jun 5, 2018
Interestingly, when I manually launch
winbuild.bat, the .msi files are built fine. However, when its' launched from Task Scheduler the .msi files don't build.Managed to capture an error message from the Wix bits, which should help track down the problem:
justinclift commentedon Jun 5, 2018
Well, the info in the URL in the error message isn't at all helpful (to me).
@karim Any idea how to solve this?
justinclift commentedon Jun 5, 2018
Ahhh, this might do the trick:
https://stackoverflow.com/questions/1064580/wix-3-0-throws-error-217-while-being-executed-by-continuous-integration
I'll turn on that SuppressValidation thing, and see if the .msi's build.
justinclift commentedon Jun 5, 2018
Cool. Adding
-svalto the light.exe command works. I'll put that to master in a sec. 😄karim commentedon Jun 5, 2018
I think it might be related to the user account on the system. Are you running the build script on a non-admin user account?
Edit: more info here wixtoolset/issues#4922
justinclift commentedon Jun 5, 2018
Yeah, it's a local user account.
But, the
-svalfix works well enough, so I'm calling this "done". 😄justinclift commentedon Dec 9, 2018
Closing this, as the new MSI based installers shouldn't be able to hang, and we're also providing .zip based ones now too. eg unzip it and people are ready to go.
If that hangs, then there's something really, really wrong. 😉