Skip to content

Prefetch block size creates unsafe grid selection! #1373

Closed

Description

@sky5walk

Details for the issue

"View - Preferences - Database - Prefetch block size" creates unsafe grid selection.
And the ? tool does not work within the preferences dialog to describe the ramifications of this setting?

At a minimum, the Results window should state:
XXX rows of YYY available returned in Nms from: select * from myDB;

Better is to return all rows when user clicks Select All [Ctrl+A] or clicks the upper left of the grid box.
This is tricky behavior.
I understand the desire to limit rows for performance, but "Select All" must = "All".
Not "Select All loaded rows".

Useful extra information

Set the Prefetch to a smallish number like 500.

Execute a SQL statement that returns more than 500.
The Results window tells the user XXX rows returned in Xms from: select * from myDB;

  • Select all resulting rows & cols - Copy to clipboard.
    Result = Only the prefetch amount of rows were selected and copied.

Scrolling beyond the prefetch amount appends additional prefetch rows.
But this is an intensive and unexpected operation to get "all" the returned rows.

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version:10 Pro_ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.1
  • 3.10.0
  • 3.9.1
  • Other: ___

I have also:

Activity

  1. justinclift commented on May 2, 2018

    @justinclift
    Member

    I understand the desire to limit rows for performance, but "Select All" must = "All".

    Yeah, thinking about it a bit more, that does make sense. 😄

  2. sky5walk commented on May 24, 2018

    @sky5walk
    Author

    Sorry to bump topic, but I wanted to request this as BUG and not Enhancement?
    This can really cause errors down the line if users select all and get only 500 records.
    There should be a popup message saying "NOT all" records selected.

  3. justinclift commented on May 24, 2018

    @justinclift
    Member

    No worries @sky5walk. 😄

  4. added
    bugConfirmed bugs or reports that are very likely to be bugs.
    and removed on May 24, 2018
  5. self-assigned this
    on Dec 15, 2018
  6. mgrojo commented on Dec 15, 2018

    @mgrojo
    Member

    @sky5walk I've polished this change, which I have left for a time in a repository copy, and have pushed it to the master branch. It will in tomorrow's nightly build.

    Whenever "Select All" is requested through keyboard shortcut or the upper-left corner, if there is data still to be loaded, it asks the user whether to continue or cancel the selection. If accepted, all the data is loaded before performing the actual selection. Then copy and paste work as expected. Plea.se, confirm it's working OK for you.

  7. sky5walk commented on Dec 15, 2018

    @sky5walk
    Author

    Thanks for the additional prompts and the progress bars!
    I tested with ~2.5M rows and now it is very clear what DB4S is delivering.
    Please close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugConfirmed bugs or reports that are very likely to be bugs.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions