Skip to content

Refactor SqliteTableModel interface #1247

Closed

Description

@MKleusberg

I was planning to do this for quite some time now because the current interface has repeatedly caused problems (like four queries per table instead of two, or the problem mentioned by @mgrojo in #1245). Instead of fixing these bugs by adding more special cases I would like to change the interface of the SqliteTableModel class completely so it is easier to maintain and easier to use too. Currently it is not clear which function fetches data and which doesn't.

I'm opening this issue for it because I probably won't have the time to do it right away.

Activity

  1. self-assigned this
    on Dec 1, 2017
  2. mgrojo commented on Dec 7, 2020

    @mgrojo
    Member

    @MKleusberg, you already did that refactoring, don't you?

  3. MKleusberg commented on Dec 11, 2020

    @MKleusberg
    MemberAuthor

    Yes, let's close this issue. I've left out parts of what I intended to achieve because they turned out to not work great in practice. But I'm done with what is easily possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions