Repository navigation
Description
Details for the issue
When using the "Show Desktop" button (far right on task bar) to minimize all apps, DB4S minimizes to its task bar icon as expected, but then the task bar icon begins to flash. It continues to flash for about 10 seconds and then it settles into a a yellow-orange-highlighted state. Once you click on the icon to restore the app window again, the taskbar icon goes back to normal.
This only happens when DB4S is window maximized or in its window normal state at the time you click the "Show Desktop" button. If DB4s is already minimized when you click "Show Desktop", it doesn't flash. Or if you minimize DB4s with its minimize button, it doesn't flash.
Maybe this is as-designed. If so, please re-consider. A flashing icon is used to alert the user to something that needs attention. In this case, there's nothing pending, or in an error state. This flashing behavior happens even if there's no database open.
Installed from this GitHub. No funky external download. File is: DB.Browser.for.SQLite-3.10.0-win64.exe
Useful extra information
I'm opening this issue because:
- DB4S is crashing
- [x ] DB4S has a bug
- DB4S needs a feature
- DB4S has another problem
I'm using DB4S on:
- [x ] Windows: (7 64bit Ultimate )
- Linux: ( distro: ___ )
- Mac OS: ( version: ___ )
- Other: ___
I'm using DB4S version:
- [x ] 3.10.0
- 3.10.0-beta*
- 3.9.1
- Other: ___
I have also:
- Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
- [x ] Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20
Activity
[-]Taskbar icon flashes[/-][+]Taskbar icon flashes on minimize[/+]justinclift commentedon Aug 24, 2017
Thanks @victor-david, yeah that doesn't sound good. It's not on purpose at all, and we'll need to look into it. 😄
chrisjlocke commentedon Aug 25, 2017
Good ol' Windows 7 again. Not sure about Win 8, but it doesn't happen on Win 10.
justinclift commentedon Aug 25, 2017
Hmmm, wonder if this is the Windows version of #934?
If so, then https://github.com/justinclift/sqlitebrowser/commit/e7933fac6dd9b881a0a7247c65c23ee0d66b75c1 might fix it. Asked a few people in the #934 issue if they could try compiling and running that, but no takers.
@victor-david If I make a one off build for you with a potential fix, would you be ok to try it?
chrisjlocke commentedon Aug 25, 2017
I'll fire up my Win 7 VM. Urgh, I feel so dirty just thinking about it. ;)
chrisjlocke commentedon Aug 25, 2017
:cringe:
chrisjlocke commentedon Aug 25, 2017
Confirmed:
Interestingly, it doesn't occur if you click the 'Show Desktop' button while a modal form in DB4S is displayed, eg, 'Edit Table Definition'.
chrisjlocke commentedon Aug 25, 2017
Turning off the 'Edit Database Cell' pane also disables this 'bug'. (View | Edit Database Cell). Changing tab doesn't help/isn't enough (eg, viewing the 'Remote' tab)
As the icon still flashes. Only removing the Edit Database Cell pane works.
Happy to try it, if you could provide a build, please.
justinclift commentedon Aug 25, 2017
Thanks @chrisjlocke. I'll kick off a build shortly. 😄
justinclift commentedon Aug 25, 2017
Build online: https://nightlies.sqlitebrowser.org/win64-onceoffs/DB%20Browser%20for%20SQLite-sqlcipher-2017-08-25-win64.exe
Note that it's About page calls itself 3.9.200, as the branch with that experimental commit in it was created during our recent beta period.
chrisjlocke commentedon Aug 25, 2017
No improvement, unfortunately.
Just to confirm the 'Edit Database Cell' pane is greyed out / disabled (and still occurs)
justinclift commentedon Aug 25, 2017
Damn. Ahhh well. Thanks for checking @chrisjlocke. 😄
It might be worth us looking through the Edit Database Cell event loop code, just to figure out what the difference is between that and the other panels. It'll probably (hopefully) turn out to be something simple.
victor-david commentedon Aug 25, 2017
@justinclift Here also. I installed your nightly just now. Problem still exists.
justinclift commentedon Aug 25, 2017
Thanks @victor-david. 😄
chrisjlocke commentedon Aug 25, 2017
I can't do much over the weekend, but next week I can try and add some debug code to see which events (or signals, in Qt speak?) are getting fired off, etc? Using a process of elimination, it should be easy to track where its occurring.
justinclift commentedon Aug 25, 2017
Good thinking. Yep, that'd help @chrisjlocke.
And we'd probably also be able to figure out if this is the same (or even related) to the Linux issue.
chrisjlocke commentedon Aug 25, 2017
\o/
justinclift commentedon Oct 12, 2017
This problem is probably fixed in our source code now, with #1168, thanks to @kehugter. 😄
There seems to be a problem with our Windows nightly builds though, so it might be a few more days though until this can be confirmed. 😦
chrisjlocke commentedon Oct 12, 2017
Thanks @kehugter and @justinclift - confirmed this version no longer flashes in the taskbar.
justinclift commentedon Oct 12, 2017
@victor-david Our Windows nightly builds were fixed faster than I'd guessed. If you're wanting a build with the flashing task bar problem fixed, then any nightly build from tomorrow morning (2017-OCT-13) onwards should be good:
https://nightlies.sqlitebrowser.org/latest/