Repository navigation
Generate a random salt when a page is encrypted before the salt is known - #633
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
This was referenced Nov 6, 2026
Member
|
This will be included in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new database reads its salt from the first 16 bytes of the file and falls back to random bytes only when that read fails. The read happens when page 1 is first encrypted, after
pager_write_pagelisthas sentSQLITE_FCNTL_SIZE_HINT. A VFS that grows the file on that hint, like the unix VFS withSQLITE_FCNTL_CHUNK_SIZEor the browseropfs-sahpoolVFS, makes the read return zeros, so every new database gets the same all-zero salt.This generates the salt when a page is encrypted before the salt is known. A connection decrypts page 1 of an existing database before writing to it, so this only happens for a new file. Existing databases still read the salt from the header.
betahas the same code.