Repository navigation
Skip the .fini_array finalizer on WebAssembly - #622
Closed
LucaCappelletti94 wants to merge 1 commit into
Closed
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
This was referenced Sep 30, 2026
Member
|
Hi @LucaCappelletti94 - This has been merged internally and will be included in the next release. Thank you for the contribution! |
Member
|
@LucaCappelletti94 4.20.0 was just released and includes this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/sqlcipher.cregisterssqlcipher_finiin a.fini_arraysection on every target that is neither Windows nor Apple. LLVM cannot emit that section for WebAssembly and stops with.fini_array sections are unsupported, so no WebAssembly build of the amalgamation compiles without a source patch. This is one of the patches mentioned in rusqlite/rusqlite#1908.The finalizer is skipped when
__wasm__is defined. Theatexit()handler registered insqlcipher_extra_initalready runs the same shutdown on runtimes that exit, and other targets see unchanged source. The resulting build passes thesqlcipher-srcinterop suite in Node.betahas the same lines and needs this too, but as I see it is stacked onprereleaseit is likely something that can be cleanly rebased there.