sqlite: reject invalid qualified column references in correlated subqueries#4249
Open
amirHdev wants to merge 1 commit intosqlc-dev:mainfrom
Open
sqlite: reject invalid qualified column references in correlated subqueries#4249amirHdev wants to merge 1 commit intosqlc-dev:mainfrom
amirHdev wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
dosubot
bot
added
size:L
- Validate qualified column references across scopes - Reject invalid qualified refs in correlated subqueries - Validate qualified refs in subqueries Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
amirHdev
force-pushed
the
sqlite-invalid-correlated-ref
branch
from
1007c8e to
21c1c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite allows some invalid correlated references to parse successfully but
fails at runtime (e.g. referencing a table alias that is not in scope).
sqlc previously accepted these queries. This PR adds a SQLite-specific
validator that walks the AST with a parent-linked scope chain and rejects
qualified column references whose table/alias is not visible.
A new end-to-end regression test reproduces the issue and verifies the fix.
Fixes: #4223