feat: add support for TimescaleDB - #748
Conversation
|
That's great! I'd suggest that we merge the first PR as soon as some of the basic things work (e.g., creating tables and inserting data). |
|
By the way, TimescaleDB seems to be an extension of PostgeSQL, so it might make sense to take a look at the Citus implementation, which re-used the basic Postgres SQLancer implementation. |
|
Yes, I found out that both TimescaleDB and Citus are extensions of PostgreSQL; I will check out Citus first. |
|
Hi, @mrigger I referenced the implementation of Citus and refactored my commit. Now we have already established the basic structure of GlobalState, Options, Error, Bug, Provider, and Schema. Am I on the right track? If so, I will continue. But before that, may I ask a question? What is these fields and why do we add them in Citus? |
I am not very sure - the Citus implementation was contributed by @nukoyluoglu. |
when I try to run Do our community get this error before? I am trying to fix this. ---- UPDATE ---- It seems that this error occurs occasionally; it's odd. Let's leave this, because now there is no such error anyway. |
getTimeScaleDBErrors() from the TimeScaleDBProvider is never used locally
… should be in lowercase!
…eat-add-timescaleDB-#24 # Conflicts: # src/sqlancer/timescaledb/TimeScaleDBProvider.java
|
@mrigger hi, I have fixed the CI errors. Could you please help with the merge? |
I think we can merge as soon as you remove the expected errors as described in my latest comment above. It seems you also need to resolve one merge conflict due to the name check change that we just merged. |
@mrigger Done! Thanks for review too. |
|
Great, thanks a lot! |

fix: #24
Hi, I am new to this project, and this is my very first commit that touches the code. I am willing to apply for GSoC 2023, and I hope this can help me get started and be more familiar with our community and project.
It is still in progress, but feel free to comment anytime!