Skip to content

Unify the option format, describe it, and automatically check it - #30

Merged
mrigger merged 3 commits into
masterfrom
option-checking
Jun 9, 2020
Merged

mrigger merged 3 commits into
masterfrom
option-checking

Conversation

@mrigger

@mrigger mrigger commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Jun 9, 2020

Copy link
Copy Markdown

Codecov Report

Merging #30 into master will increase coverage by 1.34%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #30      +/-   ##
===========================================
+ Coverage      0.00%   1.34%   +1.34%     
- Complexity        0      30      +30     
===========================================
  Files           382     382              
  Lines         18191   18193       +2     
  Branches       2337    2337              
===========================================
+ Hits              0     244     +244     
+ Misses        18191   17944     -247     
- Partials          0       5       +5     
Impacted Files Coverage Δ Complexity Δ
src/sqlancer/MainOptions.java 43.33% <ø> (+43.33%) 1.00 <0.00> (+1.00)
src/sqlancer/cockroachdb/CockroachDBOptions.java 62.50% <ø> (+62.50%) 1.00 <0.00> (+1.00)
src/sqlancer/Main.java 6.53% <90.90%> (+6.53%) 2.00 <1.00> (+2.00)
src/sqlancer/mysql/MySQLProvider.java 1.41% <0.00%> (+1.41%) 2.00% <0.00%> (+2.00%)
src/sqlancer/tidb/TiDBProvider.java 1.81% <0.00%> (+1.81%) 2.00% <0.00%> (+2.00%)
src/sqlancer/duckdb/DuckDBProvider.java 2.59% <0.00%> (+2.59%) 2.00% <0.00%> (+2.00%)
src/sqlancer/clickhouse/ClickhouseProvider.java 2.73% <0.00%> (+2.73%) 2.00% <0.00%> (+2.00%)
src/sqlancer/Randomly.java 4.00% <0.00%> (+4.00%) 2.00% <0.00%> (+2.00%)
src/sqlancer/cockroachdb/CockroachDBProvider.java 11.47% <0.00%> (+11.47%) 2.00% <0.00%> (+2.00%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d770710...82de39b. Read the comment docs.

@mrigger
mrigger merged commit 9bda897 into master Jun 9, 2020
@mrigger
mrigger deleted the option-checking branch June 9, 2020 12:41
@mrigger mrigger mentioned this pull request Jun 9, 2020
fm4v added a commit to ClickHouse/sqlancer that referenced this pull request Jun 24, 2026
…es (sqlancer#24,25,26,27,29,30)

Seven self-contained oracles (default-on, --flag gated, feature-absence tolerated):
- sqlancer#24 SequenceFunnel          windowFunnel/sequenceCount/sequenceMatch/retention == Java truth
                              (tiny deterministic fixture, far-from-boundary timestamps)
- sqlancer#25 PartitionLifecycle      DETACH+ATTACH/DROP/REPLACE/MOVE PARTITION row-set invariants
                              (SYSTEM STOP MERGES pins topology)
- sqlancer#26 AlterModifyConsistency  data-preserving ALTER MODIFY COLUMN/CODEC/TTL/SETTING + MATERIALIZE
                              must not change the visible multiset (modulo pre-applied widen cast)
- sqlancer#27 TtlDeterminism          TTL DELETE survivors == non-expired bucket; far-from-now() date
                              buckets keep the result wall-clock-independent
- sqlancer#29 InsertDedup             identical block re-insert leaves count unchanged (insert_deduplicate
                              default-on); distinct block grows; optional async arm
- sqlancer#30 TokenBf                 hasToken/=/IN with tokenbf_v1 index == use_skip_indexes=0 scan
- sqlancer#30 VectorIndexRecall       vector_similarity HNSW top-1 == brute-force top-1 + top-k containment
                              (never exact set-equality for ANN)

Completes all 30 plan ideas across 5 waves: 29 new oracles + Int128/256/Decimal256 emission +
EET roundtrip identities. ALL_ORACLES now 76 tokens; mvn package green (3.9M jar). Probe-on-head
(dev-vm): tokenbf_v1/vector_similarity grammar, windowFunnel/retention signatures, TTL materialize.
fm4v added a commit to ClickHouse/sqlancer that referenced this pull request Jun 24, 2026
- sqlancer#22 AggregateStateExpansion: AggregatingMergeTree arm used finalizeAggregation(sumMerge(s))
  which double-finalizes (Code 43 ILLEGAL_TYPE_OF_ARGUMENT); sumMerge(s)/uniqExactMerge(u)
  already return the finalized scalar. Verified on head: sumMerge=10, uniqExactMerge=3.
- ClickHouseProvider: pin allow_experimental_{variant,dynamic,json}_type +
  allow_experimental_vector_similarity_index per connection so the VariantSubcolumn (sqlancer#18) and
  VectorIndexRecall (sqlancer#30) fixtures CREATE reliably (the oracle-issued SET could land on a
  different pooled connection than the CREATE). All four settings confirmed to exist on head.

Probe (head 26.6.1.743) confirmed all other 27 new-oracle constructs work as written:
Int128/Int256/Decimal(P,S), geo fns, windowFunnel/sequenceCount/retention, lagInFrame,
WITH ROLLUP/GROUPING/TOTALS, LIMIT WITH TIES/BY, *EXCEPT/APPLY/COLUMNS, SEMI/ANTI/ANY,
CoalescingMergeTree, Set/Join/joinGet, remote(), tokenbf_v1, vector_similarity, TTL DELETE,
unhex/base64/IPv4/IPv6 roundtrips.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants