Extend EET transformed query reduction to DML - #1363
Merged
Merged
Conversation
… (e.g. incorporate rowId setup) to make it easier to verify the logs independently
Collaborator
Author
|
Independently of my changes, Yugabyte seem to have released a new Docker image which introduces a bug, revealed by the Yugabyte CI because it dynamically fetches the ':latest' image. Further investigating this bug is out of scope for this PR, so in keeping with the approach for most other DBMSs, I have pinned the CI to a specific image instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previously merged transformed query reduction (PR #1360) was for the EET SELECT oracle only. This extends the work to also benefit the EET DML oracle; the theoretical approach is the same (implementing the unchanged TransformationReproducer interface). The main difference is that a DML statement's transformable expressions vary by statement kind (e.g. UPDATE has SET values while DELETE does not), so much of the diff is to make the reproducer hold them in a fixed order with a reassembly function that rebuilds the statement string. Other parts of the diff ensure the EET DML logs clearly lay out the reduction.