Skip to content

Do not return null when PostgreSQL tablespaces are disabled #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrigger merged 1 commit into from
Aug 3, 2026
Merged

Do not return null when PostgreSQL tablespaces are disabled #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sqlancer/postgres/gen/PostgresTableSpaceGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package sqlancer.postgres.gen;

import sqlancer.IgnoreMeException;
import sqlancer.common.query.ExpectedErrors;
import sqlancer.common.query.SQLQueryAdapter;
import sqlancer.postgres.PostgresGlobalState;
Expand All @@ -19,10 +20,12 @@ public PostgresTableSpaceGenerator(PostgresGlobalState globalState) {
}

public static SQLQueryAdapter generate(PostgresGlobalState globalState) {
// Skip tablespace generation if the option is disabled
// PostgresProvider.mapActions does not schedule this action when the option is disabled, but QPG
// selects actions by index without consulting the schedule, so the generator has to report that
// it has nothing to generate.
PostgresOptions options = globalState.getDbmsSpecificOptions();
if (!options.isTestTablespaces()) {
return null;
throw new IgnoreMeException();
}
return new PostgresTableSpaceGenerator(globalState).generateTableSpace();
}
Expand Down
25 changes: 25 additions & 0 deletions test/sqlancer/postgres/gen/TestPostgresTableSpaceGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package sqlancer.postgres.gen;

import static org.junit.jupiter.api.Assertions.assertThrows;

import org.junit.jupiter.api.Test;

import sqlancer.IgnoreMeException;
import sqlancer.postgres.PostgresGlobalState;
import sqlancer.postgres.PostgresOptions;

class TestPostgresTableSpaceGenerator {

@Test
void generateIsSkippedWhenTablespacesAreDisabled() {
PostgresGlobalState state = new PostgresGlobalState();
state.setDbmsSpecificOptions(new PostgresOptions() {
@Override
public boolean isTestTablespaces() {
return false;
}
});

assertThrows(IgnoreMeException.class, () -> PostgresTableSpaceGenerator.generate(state));
}
}
Loading