Skip to content

Citus: skip INHERITS generation until citusdata/citus#8553 is fixed #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrigger merged 1 commit into from
May 2, 2026
Merged

Citus: skip INHERITS generation until citusdata/citus#8553 is fixed #1343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sqlancer/citus/CitusBugs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ public final class CitusBugs {
// https://github.com/citusdata/citus/issues/6298
public static boolean bug6298 = true;

// https://github.com/citusdata/citus/issues/8553
public static boolean bug8553 = true;

private CitusBugs() {
}

Expand Down
9 changes: 9 additions & 0 deletions src/sqlancer/citus/gen/CitusTableGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package sqlancer.citus.gen;

import sqlancer.citus.CitusBugs;
import sqlancer.common.query.SQLQueryAdapter;
import sqlancer.postgres.PostgresGlobalState;
import sqlancer.postgres.PostgresSchema;
Expand All @@ -20,4 +21,12 @@ public static SQLQueryAdapter generate(String tableName, PostgresSchema newSchem
return new CitusTableGenerator(tableName, newSchema, generateOnlyKnown, globalState).generate();
}

@Override
protected void generateInherits() {
if (CitusBugs.bug8553) {
return;
}
super.generateInherits();
}

}
2 changes: 1 addition & 1 deletion src/sqlancer/postgres/gen/PostgresTableGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ private void generateUsing() {
sb.append(globalState.getRandomTableAccessMethod());
}

private void generateInherits() {
protected void generateInherits() {
if (Randomly.getBoolean() && !newSchema.getDatabaseTablesWithoutViews().isEmpty()) {
sb.append(" INHERITS(");
sb.append(newSchema.getDatabaseTablesRandomSubsetNotEmpty().stream().map(t -> t.getName())
Expand Down
Loading