Skip to content

Remove Databend bug19738 workaround after upstream fix #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrigger merged 2 commits into from
Apr 27, 2026
Merged

Remove Databend bug19738 workaround after upstream fix #1335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba8bba
Remove Databend bug19738 workaround after upstream fix
mrigger Apr 27, 2026
cbd2847
Suppress Databend bug19773 (eager-aggregation Decimal mismatch family)
mrigger Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ jobs:
runs-on: ubuntu-latest
services:
databend:
image: datafuselabs/databend:v1.2.896-nightly
image: datafuselabs/databend:v1.2.900-nightly
env:
QUERY_DEFAULT_USER: sqlancer
QUERY_DEFAULT_PASSWORD: sqlancer
Expand Down
2 changes: 1 addition & 1 deletion src/sqlancer/databend/DatabendBugs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public final class DatabendBugs {
public static boolean bug15569 = true; // https://github.com/datafuselabs/databend/issues/15569
public static boolean bug15570 = true; // https://github.com/datafuselabs/databend/issues/15570
public static boolean bug15572 = true; // https://github.com/datafuselabs/databend/issues/15572
public static boolean bug19738 = true; // https://github.com/databendlabs/databend/issues/19738
public static boolean bug19773 = true; // https://github.com/databendlabs/databend/issues/19773

private DatabendBugs() {
}
Expand Down
7 changes: 4 additions & 3 deletions src/sqlancer/databend/DatabendErrors.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ public static List<String> getExpressionErrors() {
if (DatabendBugs.bug15568) {
errors.add("Decimal overflow at line : 723 while evaluating function `to_decimal");
}
if (DatabendBugs.bug19738) {
errors.add("UnwindError");
errors.add("unable to cast `NULL`");
if (DatabendBugs.bug19773) {
errors.add("failed to downcast column Decimal128");
errors.add("Decimal(DecimalSize { precision: 38");
errors.add("_eager_final_count");
}

/*
Expand Down
11 changes: 4 additions & 7 deletions src/sqlancer/databend/test/tlp/DatabendQueryPartitioningAggregateTester.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import sqlancer.Randomly;
import sqlancer.common.query.SQLQueryAdapter;
import sqlancer.common.query.SQLancerResultSet;
import sqlancer.databend.DatabendBugs;
import sqlancer.databend.DatabendErrors;
import sqlancer.databend.DatabendProvider.DatabendGlobalState;
import sqlancer.databend.DatabendSchema.DatabendCompositeDataType;
Expand Down Expand Up @@ -45,12 +44,10 @@ public DatabendQueryPartitioningAggregateTester(DatabendGlobalState state) {
@Override
public void check() throws SQLException {
super.check();
List<DatabendAggregateFunction> aggregateFunctions = new ArrayList<>(List.of(DatabendAggregateFunction.MAX,
DatabendAggregateFunction.MIN, DatabendAggregateFunction.SUM, DatabendAggregateFunction.COUNT
/* , DatabendAggregateFunction.STDDEV_POP */));
if (!DatabendBugs.bug19738) {
aggregateFunctions.add(DatabendAggregateFunction.AVG);
}
List<DatabendAggregateFunction> aggregateFunctions = new ArrayList<>(
List.of(DatabendAggregateFunction.MAX, DatabendAggregateFunction.MIN, DatabendAggregateFunction.SUM,
DatabendAggregateFunction.COUNT, DatabendAggregateFunction.AVG
/* , DatabendAggregateFunction.STDDEV_POP */));
DatabendAggregateFunction aggregateFunction = Randomly.fromList(aggregateFunctions);
DatabendFunctionOperation<DatabendAggregateFunction> aggregate = (DatabendAggregateOperation) gen
.generateArgsForAggregate(aggregateFunction);
Expand Down
Loading