Skip to content

Fix Materialize CI: retry readSchema to handle eventual consistency #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrigger merged 3 commits into from
Apr 25, 2026
Merged

Fix Materialize CI: retry readSchema to handle eventual consistency #1332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e81ffd1
Fix Materialize CI: retry readSchema to handle eventual consistency
mrigger Apr 19, 2026
5d2e48a
Address review feedback: fix comment and add MaterializeBugs
mrigger Apr 21, 2026
82612b1
Wrap readSchema workaround in bugSchemaReadIncomplete guard
mrigger Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/sqlancer/materialize/MaterializeBugs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package sqlancer.materialize;

// do not make the fields final to avoid warnings
public final class MaterializeBugs {

// Tables or columns may be missing when reading information_schema shortly after creation
public static boolean bugSchemaReadIncomplete = true;

private MaterializeBugs() {
}

}
27 changes: 27 additions & 0 deletions src/sqlancer/materialize/MaterializeGlobalState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ public class MaterializeGlobalState extends SQLGlobalState<MaterializeOptions, M
// store and allow filtering by function volatility classifications
private final Map<String, Character> functionsAndTypes = new HashMap<>();
private List<Character> allowedFunctionTypes = Arrays.asList(IMMUTABLE, STABLE, VOLATILE);
private int lastKnownTableCount;
private int readSchemaCallCount;

@Override
public void setConnection(SQLConnection con) {
Expand Down Expand Up @@ -266,6 +268,31 @@ public String getRandomTableAccessMethod() {

@Override
public MaterializeSchema readSchema() throws SQLException {
if (MaterializeBugs.bugSchemaReadIncomplete) {
// Workaround for a suspected Materialize bug where tables or columns may be
// missing when reading the schema; retry until stable.
readSchemaCallCount++;
for (int tries = 0; tries < 30; tries++) {
MaterializeSchema schema = MaterializeSchema.fromConnection(getConnection(), getDatabaseName());
boolean hasTableWithEmptyColumns = schema.getDatabaseTables().stream()
.anyMatch(t -> t.getColumns().isEmpty());
boolean tableCountRegressed = schema.getDatabaseTables().size() < lastKnownTableCount;
boolean suspiciouslyEmpty = readSchemaCallCount > 1 && schema.getDatabaseTables().isEmpty();
if (!hasTableWithEmptyColumns && !tableCountRegressed && !suspiciouslyEmpty) {
lastKnownTableCount = schema.getDatabaseTables().size();
return schema;
}
try {
Thread.sleep(100);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
break;
}
}
MaterializeSchema schema = MaterializeSchema.fromConnection(getConnection(), getDatabaseName());
lastKnownTableCount = schema.getDatabaseTables().size();
return schema;
}
return MaterializeSchema.fromConnection(getConnection(), getDatabaseName());
}

Expand Down
Loading