Skip to content

Replace hardcoded sleeps with readiness loops in CI workflows #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrigger merged 2 commits into from
Mar 27, 2026
Merged

Replace hardcoded sleeps with readiness loops in CI workflows #1304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
708af09
Replace hardcoded sleeps with readiness loops in CI workflows
mrigger Mar 27, 2026
8c143a3
Fix CnosDB readiness check to use TCP port probe
mrigger Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
run: |
docker pull cnosdb/cnosdb:community-latest
docker run --name cnosdb -p 8902:8902 -d cnosdb/cnosdb:community-latest
sleep 5
until nc -z 127.0.0.1 8902 2>/dev/null; do sleep 1; done
- name: Run Tests
run: |
CNOSDB_AVAILABLE=true mvn -Dtest=TestCnosDBNoREC test
Expand All @@ -137,7 +137,7 @@ jobs:
run: |
docker pull clickhouse/clickhouse-server:24.3.1.2672
docker run --ulimit nofile=262144:262144 --name clickhouse-server -p8123:8123 -d clickhouse/clickhouse-server:24.3.1.2672
sleep 5
until curl -sf http://127.0.0.1:8123/ping 2>/dev/null; do sleep 1; done
- name: Run Tests
run: CLICKHOUSE_AVAILABLE=true mvn -Dtest=ClickHouseBinaryComparisonOperationTest,TestClickHouse,ClickHouseOperatorsVisitorTest,ClickHouseToStringVisitorTest test
- name: Show fatal errors
Expand Down Expand Up @@ -166,7 +166,7 @@ jobs:
run: |
wget -qO- https://binaries.cockroachdb.com/cockroach-v24.2.0.linux-amd64.tgz | tar xvz
cd cockroach-v24.2.0.linux-amd64/ && ./cockroach start-single-node --insecure &
sleep 10
until cockroach-v24.2.0.linux-amd64/cockroach sql --insecure -e "SELECT 1" 2>/dev/null; do sleep 2; done
- name: Create SQLancer user
run: cd cockroach-v24.2.0.linux-amd64/ && ./cockroach sql --insecure -e "CREATE USER sqlancer; GRANT admin to sqlancer" && cd ..
- name: Run Tests
Expand Down Expand Up @@ -194,7 +194,7 @@ jobs:
run: |
wget -qO- https://binaries.cockroachdb.com/cockroach-v24.2.0.linux-amd64.tgz | tar xvz
cd cockroach-v24.2.0.linux-amd64/ && ./cockroach start-single-node --insecure &
sleep 10
until cockroach-v24.2.0.linux-amd64/cockroach sql --insecure -e "SELECT 1" 2>/dev/null; do sleep 2; done
- name: Create SQLancer user
run: cd cockroach-v24.2.0.linux-amd64/ && ./cockroach sql --insecure -e "CREATE USER sqlancer; GRANT admin to sqlancer" && cd ..
- name: Run Tests
Expand Down Expand Up @@ -483,7 +483,7 @@ jobs:
- name: Set up OceanBase
run: |
docker run -p 2881:2881 --name oceanbase-ce -e MODE=mini -d oceanbase/oceanbase-ce:4.2.1-lts
sleep 120
until mysql -h127.1 -uroot@test -P2881 --connect-timeout=3 -Doceanbase -A -e "SELECT 1" 2>/dev/null; do sleep 5; done
mysql -h127.1 -uroot@test -P2881 -Doceanbase -A -e"CREATE USER 'sqlancer'@'%' IDENTIFIED BY 'sqlancer'; GRANT ALL PRIVILEGES ON * . * TO 'sqlancer'@'%';"
- name: Run Tests
run: |
Expand Down Expand Up @@ -537,13 +537,13 @@ jobs:
docker pull prestodb/presto:latest
echo "connector.name=memory" >> memory.properties
docker run -p 8080:8080 -d -v ./memory.properties:/opt/presto-server/etc/catalog/memory.properties --name presto prestodb/presto:latest
sleep 30
until curl -sf http://127.0.0.1:8080/v1/info 2>/dev/null; do sleep 2; done
- name: Build SQLancer
run: mvn -B package -DskipTests=true
- name: Run Tests
run: |
PRESTO_AVAILABLE=true mvn -Dtest=TestPrestoNoREC test
docker restart presto && sleep 30
docker restart presto && until curl -sf http://127.0.0.1:8080/v1/info 2>/dev/null; do sleep 2; done
PRESTO_AVAILABLE=true mvn -Dtest=TestPrestoTLP test
sqlite:
name: DBMS Tests (SQLite)
Expand Down Expand Up @@ -607,9 +607,9 @@ jobs:
run: |
docker pull hawkingrei/tidb-playground:nightly-2025-09-16
docker run --name tidb-server -d -p 4000:4000 hawkingrei/tidb-playground:nightly-2025-09-16
sleep 10
until mysql -h 127.0.0.1 -P 4000 -u root --connect-timeout=3 -e "SELECT 1" 2>/dev/null; do sleep 3; done
- name: Create SQLancer user
run: sudo mysql -h 127.0.0.1 -P 4000 -u root -D test -e "CREATE USER 'sqlancer'@'%' IDENTIFIED WITH mysql_native_password BY 'sqlancer'; GRANT ALL PRIVILEGES ON *.* TO 'sqlancer'@'%' WITH GRANT OPTION; FLUSH PRIVILEGES;"
run: mysql -h 127.0.0.1 -P 4000 -u root -D test -e "CREATE USER 'sqlancer'@'%' IDENTIFIED WITH mysql_native_password BY 'sqlancer'; GRANT ALL PRIVILEGES ON *.* TO 'sqlancer'@'%' WITH GRANT OPTION; FLUSH PRIVILEGES;"
- name: Run Tests
run: |
TIDB_AVAILABLE=true mvn -Dtest=TestTiDBTLP test
Expand All @@ -634,9 +634,9 @@ jobs:
run: |
docker pull hawkingrei/tidb-playground:nightly-2025-09-16
docker run --name tidb-server -d -p 4000:4000 hawkingrei/tidb-playground:nightly-2025-09-16
sleep 10
until mysql -h 127.0.0.1 -P 4000 -u root --connect-timeout=3 -e "SELECT 1" 2>/dev/null; do sleep 3; done
- name: Create SQLancer user
run: sudo mysql -h 127.0.0.1 -P 4000 -u root -D test -e "CREATE USER 'sqlancer'@'%' IDENTIFIED WITH mysql_native_password BY 'sqlancer'; GRANT ALL PRIVILEGES ON *.* TO 'sqlancer'@'%' WITH GRANT OPTION; FLUSH PRIVILEGES;"
run: mysql -h 127.0.0.1 -P 4000 -u root -D test -e "CREATE USER 'sqlancer'@'%' IDENTIFIED WITH mysql_native_password BY 'sqlancer'; GRANT ALL PRIVILEGES ON *.* TO 'sqlancer'@'%' WITH GRANT OPTION; FLUSH PRIVILEGES;"
- name: Run Tests
run: TIDB_AVAILABLE=true mvn -Dtest=TestTiDBQPG test

Expand All @@ -659,7 +659,7 @@ jobs:
run: |
docker pull yugabytedb/yugabyte:latest
docker run -d --name yugabyte -p7000:7000 -p9000:9000 -p5433:5433 -p9042:9042 yugabytedb/yugabyte:latest bin/yugabyted start --daemon=false
sleep 5
until pg_isready -h localhost -p 5433; do sleep 1; done
- name: Run Tests
run: |
YUGABYTE_AVAILABLE=true mvn -Dtest=TestYSQLNoREC test
Expand Down Expand Up @@ -696,7 +696,7 @@ jobs:
cd ../be
./bin/start_be.sh --daemon

sleep 30
until mysql -u root -h 127.0.0.1 --port 9030 --connect-timeout=3 -e "SELECT 1" 2>/dev/null; do sleep 3; done
IP=$(hostname -I | awk '{print $1}')
mysql -u root -h 127.0.0.1 --port 9030 -e "ALTER SYSTEM ADD BACKEND '${IP}:9050';"
mysql -u root -h 127.0.0.1 --port 9030 -e "CREATE USER 'sqlancer' IDENTIFIED BY 'sqlancer'; GRANT ALL ON *.* TO sqlancer;"
Expand Down
Loading