Conversation
ClickHouse PR ClickHouse/ClickHouse#81835 added a check that forbids creating tables without insertable columns (e.g., tables with only MATERIALIZED or ALIAS columns). Since SQLancer's random table generator can produce such definitions, ClickHouse now returns EMPTY_LIST_OF_COLUMNS_PASSED, which should be treated as an expected error rather than causing an AssertionError. The table creation retry loop in ClickHouseProvider.generateDatabase already handles expected errors by regenerating the table definition.
alexey-milovidov
added a commit
to ClickHouse/ClickHouse
that referenced
this pull request
Mar 1, 2026
SQLancer was disabled after #81835 which forbids creating tables without insertable columns (e.g., with only `MATERIALIZED` or `ALIAS` columns). SQLancer's random table generator could produce such definitions, causing an `AssertionError`. The fix adds `EMPTY_LIST_OF_COLUMNS_PASSED` to SQLancer's expected errors. The table creation retry loop in `ClickHouseProvider.generateDatabase` already handles expected errors by regenerating the table definition. The fix was submitted upstream: sqlancer/sqlancer#1296 and applied to the ClickHouse fork: https://github.com/ClickHouse/sqlancer This PR switches CI to use the ClickHouse fork (pinned to a specific commit) and re-enables the SQLancer job in the master workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
Contributor
|
Sorry, I completely overlooked this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickHouse PR ClickHouse/ClickHouse#81835 added a check that forbids creating tables without insertable columns (e.g., tables with only
MATERIALIZEDorALIAScolumns).Since SQLancer's random table generator can produce such definitions, ClickHouse now returns
EMPTY_LIST_OF_COLUMNS_PASSED, which causes anAssertionErrorin SQLancer.This adds the error to the expected errors list. The table creation retry loop in
ClickHouseProvider.generateDatabasealready handles expected errors by regenerating the table definition, so this fix is sufficient.