Skip to content

Fix sqlancer#1249: Postgres REINDEX now generate only one index name per statement #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertZhangTJ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix sqlancer#1249: Postgres REINDEX now generate only one index name per statement #1250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/sqlancer/postgres/gen/PostgresReindexGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package sqlancer.postgres.gen;

import java.util.List;
import java.util.stream.Collectors;

import sqlancer.IgnoreMeException;
import sqlancer.Randomly;
Expand Down Expand Up @@ -39,7 +38,7 @@ public static SQLQueryAdapter create(PostgresGlobalState globalState) {
if (indexes.isEmpty()) {
throw new IgnoreMeException();
}
sb.append(indexes.stream().map(i -> i.getIndexName()).collect(Collectors.joining()));
sb.append(indexes.stream().skip(Randomly.getNotCachedInteger(0, indexes.size())).findFirst().map(i -> i.getIndexName()).orElse(""));
Copy link
Copy Markdown
Contributor

@mrigger mrigger Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks quite complex. Could we use the Randomly class to get a random element of the indexes list and obtain the name of the index?

Also, I think we should investigate why this code currently does not trigger any bugs. There might be a more fundamental issue. For example, do we only generate one index at most?

break;
case TABLE:
sb.append("TABLE ");
Expand Down
Loading