Skip to content

Commit 3024850

Browse files
authored
Merge pull request #1343 from sqlancer/fix/citus-skip-inherits-8553
Citus: skip INHERITS generation until citusdata/citus#8553 is fixed
2 parents d38ddcb + da231dd commit 3024850

3 files changed

Lines changed: 13 additions & 1 deletion

File tree

src/sqlancer/citus/CitusBugs.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ public final class CitusBugs {
3333
// https://github.com/citusdata/citus/issues/6298
3434
public static boolean bug6298 = true;
3535

36+
// https://github.com/citusdata/citus/issues/8553
37+
public static boolean bug8553 = true;
38+
3639
private CitusBugs() {
3740
}
3841

src/sqlancer/citus/gen/CitusTableGenerator.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package sqlancer.citus.gen;
22

3+
import sqlancer.citus.CitusBugs;
34
import sqlancer.common.query.SQLQueryAdapter;
45
import sqlancer.postgres.PostgresGlobalState;
56
import sqlancer.postgres.PostgresSchema;
@@ -20,4 +21,12 @@ public static SQLQueryAdapter generate(String tableName, PostgresSchema newSchem
2021
return new CitusTableGenerator(tableName, newSchema, generateOnlyKnown, globalState).generate();
2122
}
2223

24+
@Override
25+
protected void generateInherits() {
26+
if (CitusBugs.bug8553) {
27+
return;
28+
}
29+
super.generateInherits();
30+
}
31+
2332
}

src/sqlancer/postgres/gen/PostgresTableGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ private void generateUsing() {
206206
sb.append(globalState.getRandomTableAccessMethod());
207207
}
208208

209-
private void generateInherits() {
209+
protected void generateInherits() {
210210
if (Randomly.getBoolean() && !newSchema.getDatabaseTablesWithoutViews().isEmpty()) {
211211
sb.append(" INHERITS(");
212212
sb.append(newSchema.getDatabaseTablesRandomSubsetNotEmpty().stream().map(t -> t.getName())

0 commit comments

Comments
 (0)