Skip to content

Makes site and nav more mobile friendly#9

Open
matthiaswh wants to merge 1 commit into
sqlalchemyorg:mainfrom
matthiaswh:mobile-friendly
Open

Makes site and nav more mobile friendly#9
matthiaswh wants to merge 1 commit into
sqlalchemyorg:mainfrom
matthiaswh:mobile-friendly

Conversation

@matthiaswh

Copy link
Copy Markdown

These are some relatively small CSS changes to make the site read better on mobile, as well as make the navigation menu flow vertically with a collapsible toggle.

I wasn't able to test how these changes might affect the docs. I figured out how you build them with Sphinx but it wasn't clear how you pull those into the site with headers/footers. These updates should not break them, but happy to test them a little bit more if you wanted to give some instructions on your build process.

@zzzeek

zzzeek commented Mar 10, 2021

Copy link
Copy Markdown
Contributor

cool, I can give these a look!

the sqlalchemyorg part of things is run using a tool called zeekofile, that is my own fork of an old tool called blogofile. you can run the sqlalchemyorg site here using zeekofile by installing zeekofile in a python environment somewhere, then cd into the root directory of this repo and run:

$ zeekofile --serve
/home/classic/.venv3/lib/python3.8/site-packages/scss/selector.py:26: FutureWarning: Possible nested set at position 329
  SELECTOR_TOKENIZER = re.compile(r'''
Running an initial build
/home/classic/.venv3/src/zeekofile/zeekofile/_controllers/blog/post.py:198: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  y = yaml.load(yaml_src)
Blogofile server started on 127.0.0.1:8080 ...

then the site is at that web address.

you can then build the docs so they refer to this site like this:

$ RTD_SITE_BASE=http://127.0.0.1:8080 READTHEDOCS=True make clean html

(this submitted too quickly, I'm testing that out now).

edit: OK from there, right now you have to view the sphinx docs in terms of that web server. so you can copy the files over into _site/ , which is where it's serving the files from, into any directory and then view that in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants