Emit warning on direct instantiation of unmapped MappedAsDataclass - #13587
Open
VimalN2005 wants to merge 1 commit into
Open
Emit warning on direct instantiation of unmapped MappedAsDataclass#13587VimalN2005 wants to merge 1 commit into
VimalN2005 wants to merge 1 commit into
Conversation
Direct instantiation of unmapped classes (mixins or abstract base classes) using MappedAsDataclass is unsupported as ORM features and attributes cannot be resolved without concrete mapping. An SAWarning is now emitted when instantiating such classes directly. Concrete mapped subclasses remain unaffected and instantiate normally. Fixes: sqlalchemy#10064
Collaborator
|
Thanks! Issue #10064 is now marked code review in progress and no longer open for pull requests, so this pull request holds the review for it and another one won't land on top of your work. If this pull request is abandoned, a maintainer can put open for pull requests back on #10064 to reopen it to others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes: #10064
Description
Direct instantiation of unmapped classes (mixins or abstract base classes) using
MappedAsDataclassis unsupported as ORM features, column expressions, and relationship attributes cannot be resolved without a concrete mapping.Per issue discussion and maintainer guidance:
_UnmappedDataclassConfigfor classes subclassingMappedAsDataclassthat emits anSAWarningwhen the unmapped class is directly instantiated (type(self_) is cls_).Checklist
test/orm/declarative/test_dc_transforms.py(UnmappedDataclassInstantiationTest)test_dc_transforms.pyandtest_dataclasses.pypass cleanlydoc/build/changelog/unreleased_21/10064.rst