Apply tuple bind expressions to expanding IN values - #13323
Open
puneetdixit200 wants to merge 1 commit into
Open
puneetdixit200 wants to merge 1 commit into
puneetdixit200 wants to merge 1 commit into
Conversation
Sanjays2402
reviewed
Jul 19, 2026
| bind_expression = impl.bind_expression( | ||
| elements.literal_column(replacement, type_=typ) | ||
| ) | ||
| return self.process( |
There was a problem hiding this comment.
bind_expression() can introduce its own bind params (for example, func.coalesce(bindvalue, "fallback")). Calling self.process() from postcompile expansion then mutates self.binds while _process_parameters_for_postcompile() is iterating it, so this tuple fails compilation with RuntimeError: dictionary changed size during iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tuple-valued expanding parameters now apply each element type's
bind_expression()when rendering expanded tuples. This matches scalarINbehavior for custom types and covers bothrender_postcompileandliteral_binds.Fixes: #8992
Checklist
This pull request is:
test/sql/test_type_expressions.pyLocal checks:
uv run --group tests pytest test/sql/test_type_expressions.py -quv run --group tests pytest test/sql/test_compiler.py -q -k "tuple_expanding_in or expanding_parameter"uv run --group lint flake8 lib/sqlalchemy/sql/compiler.py test/sql/test_type_expressions.pyuv run --group lint black --check lib/sqlalchemy/sql/compiler.py test/sql/test_type_expressions.py