Skip to content

test_limit_render_multiple_times needs order by and seems to be the only union type test. #6468

Description

@jimfulton

This line:

stmt = select(table.c.id).limit(1).scalar_subquery()

is missing an order_by.

The test assumes select ordering. I'm maintaining the Google BigQuery dialect and this test failed as written because the result was [(4,)] without the order_by.

BTW, this test detected that we were doing union wrong. We were assuming that union() wanted UNION ALL not UNION DISTINCT. It would be good to have a dedicated test for that.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtests

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions