Skip to content

Remove obsolete JUnit 4 reference from CONTRIBUTING documentation - #52370

Open
akashshri5795 wants to merge 2 commits into
spring-projects:mainfrom
akashshri5795:main
Open

akashshri5795 wants to merge 2 commits into
spring-projects:mainfrom
akashshri5795:main

Conversation

@akashshri5795

@akashshri5795 akashshri5795 commented Oct 23, 2026 •

Copy link
Copy Markdown

This PR addresses issue #48072 by fixing two documentation issues:

  1. Removed the obsolete JUnit 4 reference from the CONTRIBUTING documentation.
  2. Fixed a copy-paste typo in test-modules.adoc where Spring Data Neo4j was incorrectly described as Spring Data JPA.

Closes #48072

Signed-off-by: Akash Shrivastava <117969103+akashshri5795@users.noreply.github.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue that has not yet been triaged. Contributions will not be accepted. label Oct 23, 2026
Signed-off-by: Akash Shrivastava <117969103+akashshri5795@users.noreply.github.com>
Comment thread CONTRIBUTING.adoc
You can also install the https://github.com/spring-io/spring-javaformat/#intellij-idea[Spring JavaFormat IntelliJ Plugin] or format the code from the Gradle build by running `./gradlew format`.
Note that if you have format violations in `buildSrc`, you can fix them by running `./gradlew -p buildSrc format` from the project root directory.
* The build includes Checkstyle rules for many of our code conventions. Run `./gradlew checkstyleMain checkstyleTest` if you want to check your changes are compliant.
* Make sure all new `.java` files have a Javadoc class comment with at least an `@author` tag identifying you, and preferably at least a paragraph on what the class is for.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed?

@wilkinsona wilkinsona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment for your consideration.

I cannot see the connection between the proposed changes and #48072. Can you please elaborate?

@bclozel bclozel closed this Oct 23, 2026
@bclozel bclozel reopened this Oct 23, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue that has not yet been triaged. Contributions will not be accepted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document Spring Boot modules

4 participants