Repository navigation
Conversation
Prior to 4.1, when both a JwtDecoder and an OpaqueTokenIntrospector were available, the resource server's opaque token configuration backed off and only the JWT security filter chain was defined. Since the filter chains were moved to OAuth2ResourceServerWebSecurityAutoConfiguration, both are defined. A servlet application fails to start with an UnreachableFilterChainException and a reactive application has an opaque token chain that is never used. This commit makes the opaque token filter chain conditional on a missing JwtDecoder (ReactiveJwtDecoder for reactive) so that JWT is used, as before. Signed-off-by: WooSeung Kim <wooseung.dev@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With both
spring.security.oauth2.resourceserver.jwt.jwk-set-uriandspring.security.oauth2.resourceserver.opaquetoken.introspection-uriset and no user-defined filter chain, 4.0.x uses JWT, as it has since 2.3 (#19426). With 4.1.0 and 4.1.1, a servlet application fails to start:Since #43978 both chains are defined in
OAuth2ResourceServerWebSecurityAutoConfiguration, and the test assertion that JWT is used was dropped in the same change. A reactive application gets an opaque token chain that is never used.This makes the opaque token filter chains conditional on a missing
JwtDecoder/ReactiveJwtDecoder. The decoder and introspector beans are unaffected. The new tests fail without the change.