Repository navigation
Preserve read-ahead exceptions in SingleItemPeekableItemReader - #5603
Open
nippyclouding wants to merge 1 commit into
Open
nippyclouding wants to merge 1 commit into
nippyclouding wants to merge 1 commit into
Conversation
Cache delegate read failures until read consumes them and retain the pre-peek checkpoint while a failure is pending. Closes spring-projectsgh-1234 Signed-off-by: Lee Sang Won <nippyclouding@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the delegate throws during
peek(), a subsequentpeek()orread()advances past the failed item. A checkpoint taken before consuming that failure can also skip the item on restart.Cache the read-ahead exception until
read()consumes it, and preserve the pre-peek checkpoint while the exception is pending. Clear the cached exception onopen()andclose(). Add regression coverage for repeated peeks, exception consumption, lifecycle resets, and restart positions using aFlatFileItemReader.Closes #1234
Validation on Temurin JDK 25:
./mvnw -B -ntp -pl spring-batch-infrastructure -Dtest=SingleItemPeekableItemReaderTests,SingleItemPeekableItemReaderBuilderTests testpasses (12 tests)../mvnw -B -ntp packagepasses for all modules.