Improve SimpleStepHandler::shouldStart to handle NoSuchStepException correctly#5257
Open
quaff wants to merge 1 commit intospring-projects:mainfrom
Open
Improve SimpleStepHandler::shouldStart to handle NoSuchStepException correctly#5257quaff wants to merge 1 commit intospring-projects:mainfrom
SimpleStepHandler::shouldStart to handle NoSuchStepException correctly#5257quaff wants to merge 1 commit intospring-projects:mainfrom
Conversation
…n correctly We should treat no such step as step was not executed before. See spring-projects#5252 Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
marschall
reviewed
Feb 2, 2026
| @@ -1,2 +1,2 @@ | |||
| /* | |||
| * Copyright 2006-2025 the original author or authors. | |||
Contributor
Author
There was a problem hiding this comment.
@fmbenhassine I think all sources should be updated to Copyright 2006-present, like other spring project does.
Contributor
There was a problem hiding this comment.
Yes, however, we should do it incrementally (as we currently do), otherwise we would have to rebase all PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should treat no such step as step was not executed before.
See #5252