Lookup available JobRegistry from context for JobOperatorFactoryBean#5200
Lookup available JobRegistry from context for JobOperatorFactoryBean#5200quaff wants to merge 1 commit intospring-projects:mainfrom
JobRegistry from context for JobOperatorFactoryBean#5200Conversation
|
Thank you for the PR! However, as mentioned in #5229 (comment) , this introduces a breaking change and is not consistent with how other optional components are customized (why would we use an The way to fix the issue is by looking for a registry from the context before creating a default one (similar to what we do for the datasource and the transaction manager in the JDBC config. Can you please update the PR accordingly? Thank you upfront. As a side note, regarding spring-projects/spring-boot#48992 (comment), this is not an oversight. The class is designed to accept mandatory dependencies as constructor parameters, while optional dependencies can be customized by overriding getters (the registry is optional starting from v6). |
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
|
Updated. |
|
Another question, is registry job the responsibility of I suggest latter, and remove logic from |
No description provided.