-
Notifications
You must be signed in to change notification settings - Fork 23
Feature - Bourbon Upgrade #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rodrigodalcindev
wants to merge
152
commits into
master
Choose a base branch
from
feature/bourbon-neat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
152 commits
Select commit
Hold shift + click to select a range
413fddb
Removed spec/dummy/public/spree files
22385b7
Updates gitignore.
396cd37
Merge branch 'master' into feature/bourbon-neat
b759356
Merge branch 'master' into feature/bourbon-neat
91f27ff
Gets rid of bootstrap dependencies.
314b7da
Converts master stylesheet to SASS.
e52c645
Gets rid of assorted JS Bootstrap dependencies.
7607431
Removes manual Bootstrap library requirements from sprangular.rb
2b8915f
Gets rid of angular-motion stylesheet.
1c8c8ba
Removes ui.bootstrap and mcgrea.ngStrap from the application module.
07122dc
Gets rid of Bootstrap-related gems.
b18a6da
Adds Bourbon and Neat to gemspec.
ee35056
Requires Bourbon and Neat on sprangular.rb.
1c667d1
Imports Bourbon and Neat on stylesheet manifest.
0f1e188
Overrides stylesheet manifest, generates Bitters scaffolding.
6b21ecc
Converts Bitter scaffolding files to SASS.
6d96dbe
Imports normalize.css for styles resetting.
856afab
Updates header navigation markup.
30ebce2
Moves Bitter-generated stylesheet scaffolding over to source manifest.
e7d7248
Gets rid of navigation bar partials.
9e60fb9
Imports Refill stylesheet for navigation bar.
bfc3b31
Fixes markup on navigation bar.
dd348a8
Strips out Bootstrap grid class names from application layout.
b531197
Strips out Bootstrap grid class names from product listing view.
4eff894
Creates module stylesheet to handle listing grids.
7ed7e56
Conforms product listing grid to proper conventions.
a4d0397
Extends button styles to .button class.
3fc3514
Creates stylesheet to handle form element components.
0429431
Adds form stylesheet to manifest file.
ff923f0
Scaffolds markup for dropdown directive template.
bc49c70
Creates Angular directive for dropdown component.
436e5a7
Refactors variant selection in order to use dropdown component.
98664fc
Bye bye bootstrap
joshnuss 45d97aa
Added intialization values dict. in variantSelection, when no variant…
joshnuss e3695fc
Refactored Product.options to simplify key structure
joshnuss 605ad47
Refactored variant-selection to $watch `values` instead of manual cal…
joshnuss d4d11ec
Refactored `dropdown` directive to use ngModel
joshnuss def2ca0
Ensures only one variant selection dropdown can be open at a time.
6248964
Removes forced width from grid container on product listing view.
dea4053
Merges master into feature/bourbon-neat.
4c527eb
Groups user and cart elements into dashboard placeholder on header.
980dd5d
Re-organizes stylesheet hierarchy.
1c06044
Adds z-index strata to variables stylesheet.
2e8e858
Renames global variables across stylesheets.
ab983c7
Increases grid container width.
fe68b8e
Resets margins on form elements.
f01c8c3
Refines top navigation styles.
a521582
Adds Sprangular logo to top navigation.
99ccbe5
Includes helpers stylesheet to application.
e1aa440
Changes application loader styles.
3a0a030
Creates stylesheet for handling of global layout styles.
c74e43c
Ensures grid container exists as its own wrapper on header and produc…
1cddb41
Creates dedicated stylesheet for flash messages.
da30730
Applies markup changes to jumbotron template.
cb8c7df
Adds chevron to CTA button on jumbotron template.
76f0a10
Sets styles to cart module on header navigation.
f1cc70f
Applies changes to footer markup and styles.
8808e7a
New color variable.
3257bd7
Removes bottom margin from flash modules.
330c947
Applies changes to markup on product listing and add to car button te…
36f8e04
Adjusts product listing styles accordingly.
eb4335c
Reverts model back to pre-master merge version.
1de5c61
Refactors styles of dropdown components.
aa7b2b0
Ensures dropdowns span 100% of list items on product listing view.
a01a85a
Refactors variant selection directive.
c22b428
Sets background color on dropdown container.
1b181e3
Detaches add to cart button from its wrapper.
6ca6ed5
Adjusts listing styles to accommodate changes on variant selection di…
c916a36
Ensures height of product listing items is consistent.
3051e04
Removes top and bottom padding of buttons in favor of line-height.
45701e6
Sets styles to presentation tags on variant selection module.
99faf6e
Moves product list pagination to its own layout partial.
0b9ea14
Adjusts markup on pagination partial.
667c5ed
Creates dedicated stylesheet and sets styles to pagination module.
503bc46
Markup cleanup on product show template.
479e3c2
Cleanup markup on partial templates of product view.
0de222f
Nests cart controls under details section on product show template.
304f0bb
Creates specific stylesheet and sets up grid structure on product sho…
d134024
Uses semantic approach on product gallery partial's markup.
e203c6d
Resets margins on figure element.
96c095e
Sets grid columns for product gallery thumbnails.
3a6fbbd
Revert "Reverts model back to pre-master merge version."
joshnuss 4b7fead
Moves global style rules for variant selector over to dropdown module…
18fa03a
Adds top and bottom paddings to product details page werapper.
0bee985
Introduces color variation for button elements.
512add0
Increases height of form input elements.
a218f54
Utilitary display class.
919aaa3
Ensures dropdown wrapper positioning rules are global.
358c56c
Assigns proper formatting class to checkout button on product details…
89c54c7
Refactors markup of product properties partial.
ca31d11
Adjusts markup on product details page.
c4c4b06
Sets styles to product details page.
8ff87d4
Ensures footer sticks to the bottom of the page.
3675bca
Re-instates basic cart toggling functionality on application header.
556fbe5
Adjusts top padding on search field.
dad5f58
Creates modular stylesheet for cart.
c6a951a
Extends toggling functionality to close button on cart module.
157a535
Sets dropdown container width as global rule.
0f13246
Creates badge mixin.
029cc2d
Adjusts height of header module.
5fa65d3
Removes badge class from quantity on cart button.
bf3126f
Adjusts markup of promo code form.
11f3613
Introduces color variation for button elements.
e0d537d
Sets up clearfix class.
0685757
Adjusts markup on cart partial.
1bf2248
Sets styles to cart module.
bb8699a
Adds helper mixin for flash messages.
9b20fe0
Refactors extended and modular styles for flash messages.
a64c590
Updates markup of flash messages.
1173711
Sets styles for close icon on flash messages.
88f6b6a
Introduces new style variation for button elements.
626418b
Creates specific stylesheet to handle styles on user-related views.
3bad2f9
Adds utilitary floating classes to layout stylesheet.
13cef42
Removes fixed width from variants module on product details view.
7ca0849
Adds bottom margin to form group wrappers.
39cddda
Adjusts markup on sign in page.
d9bda68
Extends auth markup template to sign up page.
463e9dc
Applies proper color to inline error messages on forms.
114bcfe
Extends auth markup template to password resetting page.
43ad515
Conforms account page to auth markup.
8ea6f16
Moves grid-related styles to proper core stylesheet, updates syntax.
43e4488
Creates utilitary grid column class.
1324479
Updates grid-based auth layouts.
92d8017
Creates specific stylesheet to handle styles on checkout pages.
58c4b24
Scaffolds checkout index view into three separate columns.
1a6f314
Changes subheading elements on checkout index view.
7dc70a4
Removes bottom margin from select elements.
24f6299
Updates markup on billing and shipping address forms.
9887172
Wraps select element for existing addresses into from group wrapper.
cfbe623
Applies markup changes to shipping rates partial.
fce07b4
Removes bottom margin from error message snippets.
079fb03
Wraps select element for existing credit cards into form group wrapper.
2c5ee7a
Applies markup changes to credit card form partial.
27ad963
Sets preliminary styles to checkout index page.
d49b8d4
Adjusts markup and spacing of checkout summary items.
90b6e17
Un-nests promo code form and checkout confirmation button from summar…
0075160
Applies markup changes to checkout promo code form.
c3efc2c
Sets styles to checkout summary and promo code modules.
3c25ca2
Includes module stylesheet to handle breadcrumb elements.
5818c8a
Extends breadcrumb styles to checkout inner navigation.
0b09ea0
Migrations.
c5b9692
Merges master into feature/bourbon-neat.
9298b76
Removes bottom margin from form elements.
d94ebd2
Adjusts overflow on cart module.
ac8e4ae
Adjusts markup of promo form partial on cart module.
41d5663
Cart module should be fixed-positioned.
7521fb4
Removes border radius from form input elements.
b555e65
Migrations.
cd7f63f
Merges master into feature/bourbon-neat.
fc49b3c
Refactors variant selector styles.
0cc7947
Changes functionality of variant selection directive.
422ca98
Refactors use of variant selection on product-related templates.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,4 @@ spec/dummy/log/*.log | |
| spec/dummy/tmp/ | ||
| spec/dummy/public/spree | ||
| spec/dummy/.sass-cache | ||
| .ruby-version | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
app/assets/javascripts/sprangular/directives/dropdown.coffee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| 'use strict' | ||
|
|
||
| Sprangular.directive 'dropdown', ($parse) -> | ||
| restrict: 'E' | ||
| require: ['?ngModel'] | ||
| templateUrl: 'directives/dropdown.html' | ||
| scope: | ||
| description: '@' | ||
| label: '@' | ||
| options: '=' | ||
| class: '=' | ||
| emptyMessage: '@' | ||
|
|
||
| link: (scope, element, attrs, ctrls) -> | ||
| ngModelCtrl = ctrls[0] | ||
|
|
||
| if !attrs.emptyMessage | ||
| attrs.emptyMessage = '-- Choose --' | ||
|
|
||
| scope.model = ngModelCtrl | ||
|
|
||
| controller: ($scope) -> | ||
| $scope.expanded = false | ||
| $scope.sibling = null | ||
|
|
||
| $scope.expand = -> | ||
| $scope.sibling = $scope.$parent.$$prevSibling || $scope.$parent.$$nextSibling | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line exceeds maximum allowed length |
||
|
|
||
| if($scope.$parent.$parent.isVariantOpen) | ||
| $scope.sibling.$$childHead.expanded = false | ||
|
|
||
| $scope.expanded = true | ||
| $scope.$parent.$parent.isVariantOpen = true | ||
|
|
||
| $scope.displayValue = (val) -> | ||
| return unless val | ||
|
|
||
| if $scope.label | ||
| eval "val.#{$scope.label}" | ||
| else | ||
| val | ||
|
|
||
| $scope.select = (value) -> | ||
| $scope.model.$setViewValue(value) | ||
| $scope.expanded = false | ||
| $scope.$parent.$parent.isVariantOpen = false | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line exceeds maximum allowed length